Issue 10911153: Intrinsify Float32Array_getIndexed on IA32 and X64.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+151 lines, -88 lines)			Patch
M	runtime/vm/intrinsifier.h	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier_ia32.cc	View	1 2 3 4 5	1 chunk	+30 lines, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View	1 2 3 4 5	1 chunk	+31 lines, -0 lines	0 comments	Download
A +	tests/standalone/float_array_test.dart	View	1 2 3 4 5	1 chunk	+88 lines, -88 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

I added myself as reviewer, but normally you would do that :-). LGTM with comments. ...

8 years, 3 months ago (2012-09-09 14:26:51 UTC) #1

Cutch

https://chromiumcodereview.appspot.com/10911153/diff/1/runtime/vm/intrinsifier.h File runtime/vm/intrinsifier.h (right): https://chromiumcodereview.appspot.com/10911153/diff/1/runtime/vm/intrinsifier.h#newcode85 runtime/vm/intrinsifier.h:85: V(_Float32Array, [], Float32Array_getIndexed) \ On 2012/09/09 14:26:51, srdjan wrote: ...

8 years, 3 months ago (2012-09-10 14:44:42 UTC) #2

srdjan

8 years, 2 months ago (2012-09-28 22:42:08 UTC) #4

LGTM with comments

https://chromiumcodereview.appspot.com/10911153/diff/14001/runtime/vm/intrins...
File runtime/vm/intrinsifier_ia32.cc (right):

https://chromiumcodereview.appspot.com/10911153/diff/14001/runtime/vm/intrins...
runtime/vm/intrinsifier_ia32.cc:560: 
Two empty lines between functions (here and elsewhere).

https://chromiumcodereview.appspot.com/10911153/diff/14001/runtime/vm/intrins...
runtime/vm/intrinsifier_ia32.cc:563: // __ int3();
Indent should be two spaces.

Remove // __ int3();

https://chromiumcodereview.appspot.com/10911153/diff/14001/runtime/vm/intrins...
File runtime/vm/intrinsifier_x64.cc (right):

https://chromiumcodereview.appspot.com/10911153/diff/14001/runtime/vm/intrins...
runtime/vm/intrinsifier_x64.cc:519: 
Two empty lines between functions.

https://chromiumcodereview.appspot.com/10911153/diff/14001/runtime/vm/intrins...
runtime/vm/intrinsifier_x64.cc:521: Label fall_through;
Indent should be two spaces.

https://chromiumcodereview.appspot.com/10911153/diff/14001/tests/standalone/f...
File tests/standalone/float_array_test.dart (right):

https://chromiumcodereview.appspot.com/10911153/diff/14001/tests/standalone/f...
tests/standalone/float_array_test.dart:5: // Dart test program for testing
native float arrays
Terminate comments with '.'.

It seems you did svn cp. Normally we do svn add for new file, since the history
of the original file does not matter

Expand Messages | Collapse Messages