Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Unified Diff: runtime/vm/intrinsifier_x64.cc

Issue 10911153: Intrinsify Float32Array_getIndexed on IA32 and X64. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fixed all previous issues Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intrinsifier_ia32.cc ('k') | tests/standalone/float_array_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intrinsifier_x64.cc
diff --git a/runtime/vm/intrinsifier_x64.cc b/runtime/vm/intrinsifier_x64.cc
index 2b812f90d1f244dd0d3d7ea75c4d6c2061767315..741a97ded00ebb9d4dd338a55e89dfbbe001c943 100644
--- a/runtime/vm/intrinsifier_x64.cc
+++ b/runtime/vm/intrinsifier_x64.cc
@@ -517,6 +517,37 @@ bool Intrinsifier::Uint32Array_getIndexed(Assembler* assembler) {
return false;
}
+bool Intrinsifier::Float32Array_getIndexed(Assembler* assembler) {
+ Label fall_through;
+ TestByteArrayIndex(assembler, &fall_through);
+ // After TestByteArrayIndex:
+ // * RAX has the base address of the byte array.
+ // * RBX has the index into the array.
+ // RBX contains the SMI index which is shifted left by 1.
+ // This shift means we only multiply the index by 2 not 4 (sizeof float).
+ // Load single precision float into XMM7.
+ __ movss(XMM7, FieldAddress(RAX, RBX, TIMES_2,
+ Float32Array::data_offset()));
+ // Convert into a double precision float.
+ __ cvtss2sd(XMM7, XMM7);
+ // Allocate a double instance.
+ const Class& double_class = Class::Handle(
+ Isolate::Current()->object_store()->double_class());
+ AssemblerMacros::TryAllocate(assembler,
+ double_class,
+ &fall_through,
+ Assembler::kNearJump, RAX);
+ // Store XMM7 into double instance.
+ __ movsd(FieldAddress(RAX, Double::value_offset()), XMM7);
+ __ ret();
+ __ Bind(&fall_through);
+ return false;
+}
+
+bool Intrinsifier::Float32Array_setIndexed(Assembler* assembler) {
+ return false;
+}
+
// Tests if two top most arguments are smis, jumps to label not_smi if not.
// Topmost argument is in RAX.
« no previous file with comments | « runtime/vm/intrinsifier_ia32.cc ('k') | tests/standalone/float_array_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698