Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1287)

Issue 10911120: Cleanup and fixes to some dart:io files (Closed)

Created:
8 years, 3 months ago by Søren Gjesse
Modified:
8 years, 3 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org, danrubel
Visibility:
Public.

Description

Cleanup and fixes to some dart:io files Fixed wrong names for constants and some warnings. This includes the changes in https://chromiumcodereview.appspot.com/10913096/. R=ager@google.com BUG=dart:4711 Committed: https://code.google.com/p/dart/source/detail?r=11921

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -35 lines) Patch
M runtime/bin/http.dart View 1 chunk +23 lines, -23 lines 0 comments Download
M runtime/bin/http_parser.dart View 3 chunks +2 lines, -4 lines 0 comments Download
M runtime/bin/string_stream.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M runtime/bin/websocket_impl.dart View 3 chunks +0 lines, -4 lines 0 comments Download
M tests/standalone/io/http_headers_test.dart View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Gjesse
8 years, 3 months ago (2012-09-06 07:19:04 UTC) #1
Mads Ager (google)
8 years, 3 months ago (2012-09-06 07:22:57 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698