Test dart2js checked mode.

Test dart2js checked mode.

Committed: https://code.google.com/p/dart/source/detail?r=11873

[ahe, 2012-09-05 11:50:17]

Yes, we do want to test checked mode.

Yes, this may increase build bot cycle time.

Yes, we may need more build bots.

[kasperl, 2012-09-05 11:54:20]

LGTM.

https://chromiumcodereview.appspot.com/10911094/diff/1/dart/utils/compiler/bu...
File dart/utils/compiler/buildbot.py (right):

https://chromiumcodereview.appspot.com/10911094/diff/1/dart/utils/compiler/bu...
dart/utils/compiler/buildbot.py:168: # TODO(ahe): This pre-dates the shard
feature and should be
It actually doesn't predate sharding. I changed it to use sharding at some
point, but it was changed back (by Emily if I recall correctly) because people
preferred a slow and a fast bot.

Personally, I prefer the simplicity of using the generic sharding because the
current way makes it super easy to forget adding new test suites to one or the
other IE bot.

[ngeoffray, 2012-09-05 11:55:02]

LGTM! Go red :)

[Emily Fortuna, 2012-09-05 16:28:53]

https://chromiumcodereview.appspot.com/10911094/diff/1/dart/utils/compiler/bu...
File dart/utils/compiler/buildbot.py (right):

https://chromiumcodereview.appspot.com/10911094/diff/1/dart/utils/compiler/bu...
dart/utils/compiler/buildbot.py:168: # TODO(ahe): This pre-dates the shard
feature and should be
On 2012/09/05 11:54:20, kasperl wrote:
> It actually doesn't predate sharding. I changed it to use sharding at some
> point, but it was changed back (by Emily if I recall correctly) because people
> preferred a slow and a fast bot.
> 
> Personally, I prefer the simplicity of using the generic sharding because the
> current way makes it super easy to forget adding new test suites to one or the
> other IE bot.

Yes, Peter, this comment is incorrect. This was done after sharding was
implemented so that we could have some fast feedback on Windows bots by focusing
on tests that were most likely to be affected by the browser environment on our
fast bot. See the comment immediately below this for that explanation.

https://chromiumcodereview.appspot.com/10911094/diff/1/dart/utils/compiler/bu...
dart/utils/compiler/buildbot.py:242: # TODO(ahe): See comment above regarding
how to use sharding to
Please remove -- this comment is incorrect.

[ahe, 2012-09-05 19:24:30]

https://chromiumcodereview.appspot.com/10911094/diff/1/dart/utils/compiler/bu...
File dart/utils/compiler/buildbot.py (right):

https://chromiumcodereview.appspot.com/10911094/diff/1/dart/utils/compiler/bu...
dart/utils/compiler/buildbot.py:168: # TODO(ahe): This pre-dates the shard
feature and should be
On 2012/09/05 16:28:53, Emily Fortuna wrote:
> On 2012/09/05 11:54:20, kasperl wrote:
> > It actually doesn't predate sharding. I changed it to use sharding at some
> > point, but it was changed back (by Emily if I recall correctly) because
people
> > preferred a slow and a fast bot.
> > 
> > Personally, I prefer the simplicity of using the generic sharding because
the
> > current way makes it super easy to forget adding new test suites to one or
the
> > other IE bot.
> 
> Yes, Peter, this comment is incorrect. This was done after sharding was
> implemented so that we could have some fast feedback on Windows bots by
focusing
> on tests that were most likely to be affected by the browser environment on
our
> fast bot. See the comment immediately below this for that explanation.

The only part of the comment that is incorrect is "this pre-dates the shard
feature".

Sharding can be used to implement this.

The problem with the current solution is that it requires constant maintenance.
Explicit lists of test suites quickly become obsolete, and that has already
happened. For example, 'pkg' and 'dartdoc' are in defaultTestSelectors in
tools/testing/dart/test_options.dart, but not below.