Issue 10911013: Enable warning for old catch syntax

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10911013: Enable warning for old catch syntax (Closed)

Created:
8 years, 3 months ago by Brian Wilkerson

Modified:
8 years, 3 months ago

Reviewers:
scheglov, kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Enable warning for old catch syntax Committed: https://code.google.com/p/dart/source/detail?r=11640

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -19 lines)			Patch
M	compiler/java/com/google/dart/compiler/ast/DartToSourceVisitor.java	View	1	1 chunk	+9 lines, -9 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/ast/DartToSourceVisitorTest.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

8 years, 3 months ago (2012-09-03 10:29:54 UTC) #3

Thanks a lot for doing this, Brian! We're removing support for the old syntax
from the VM and dart2js. What would it take to turn this into a proper error?

Expand Messages | Collapse Messages