Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Unified Diff: compiler/java/com/google/dart/compiler/ast/DartToSourceVisitor.java

Issue 10911013: Enable warning for old catch syntax (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | compiler/java/com/google/dart/compiler/parser/DartParser.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiler/java/com/google/dart/compiler/ast/DartToSourceVisitor.java
===================================================================
--- compiler/java/com/google/dart/compiler/ast/DartToSourceVisitor.java (revision 11616)
+++ compiler/java/com/google/dart/compiler/ast/DartToSourceVisitor.java (working copy)
@@ -554,20 +554,20 @@
return null;
}
- private void visitCatchParameter(DartParameter x) {
- if (!x.getModifiers().isFinal() && x.getTypeNode() == null) {
- p("var ");
- }
- accept(x);
- }
-
@Override
public Void visitCatchBlock(DartCatchBlock x) {
+ DartParameter catchParameter = x.getException();
+ DartTypeNode type = catchParameter.getTypeNode();
+ if (type != null) {
+ p("on ");
+ accept(type);
+ p(" ");
+ }
p("catch (");
- visitCatchParameter(x.getException());
+ accept(catchParameter.getName());
if (x.getStackTrace() != null) {
p(", ");
- visitCatchParameter(x.getStackTrace());
+ accept(x.getStackTrace());
}
p(") ");
accept(x.getBlock());
« no previous file with comments | « no previous file | compiler/java/com/google/dart/compiler/parser/DartParser.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698