Fix issue 2933 - if an exception is thrown before we start the first test, but after the testcase i…

Fix issue 2933 - if an exception is thrown before we start the first test, but after the testcase is created, don't pass the error to the test case but treat it as an uncaught error.
Committed: https://code.google.com/p/dart/source/detail?r=12077

[Siggi Cherem (dart-lang), 2012-09-07 17:13:23]

lgtm
(see comment below)

https://chromiumcodereview.appspot.com/10909123/diff/1/pkg/unittest/unittest....
File pkg/unittest/unittest.dart (right):

https://chromiumcodereview.appspot.com/10909123/diff/1/pkg/unittest/unittest....
pkg/unittest/unittest.dart:665: if (testCase.running) {
seems that this means that also tests that fail after they are done running
(e.g. when an async test creates more callbacks than expected and some callbacks
happen afterwards), then we'll also mark the error as an uncaught top level
error. Is that what we want there too? or do we need to have a different state
for before/after running?

[gram, 2012-09-07 17:40:53]

https://chromiumcodereview.appspot.com/10909123/diff/1/pkg/unittest/unittest....
File pkg/unittest/unittest.dart (right):

https://chromiumcodereview.appspot.com/10909123/diff/1/pkg/unittest/unittest....
pkg/unittest/unittest.dart:665: if (testCase.running) {
On 2012/09/07 17:13:23, sigmund wrote:
> seems that this means that also tests that fail after they are done running
> (e.g. when an async test creates more callbacks than expected and some
callbacks
> happen afterwards), then we'll also mark the error as an uncaught top level
> error. Is that what we want there too? or do we need to have a different state
> for before/after running?

I thought about that. I have mixed feelings about this. In a way, 'uncaught
error' seems like a valid way of handling this, and can possibly lead to us
simplifying the code later on, as right now we have some extra checks to deal
with the fact that an error might happen on a test that is not the currently
running test. As it is, we recently made the change where a later failure will
flip the test from pass/fail to error.

OTOH I also feel that this side effect is not really desirable in that the fix
should really address just the issue at hand. As such I have come up with an
alternative that is more specific to this issue. PTAL.

[Siggi Cherem (dart-lang), 2012-09-07 19:27:37]

lgtm with comment below

https://chromiumcodereview.appspot.com/10909123/diff/1003/pkg/unittest/unitte...
File pkg/unittest/unittest.dart (right):

https://chromiumcodereview.appspot.com/10909123/diff/1003/pkg/unittest/unitte...
pkg/unittest/unittest.dart:666: if (testCase.running) {
this part should probably go away? (seems that you reverted the change that
added .running to test case)