Fix issue 2933 - if an exception is thrown before we start the first test, but after the testcase i…

pkg/unittest/unittest.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * A library for writing dart unit tests.
  *
  * To import this library, specify the relative path to
  * pkg/unittest/unittest.dart.
  *
@@ skipping 562 matching lines @@
   // Groups can be nested, so we need to preserve the current
   // settings for test setup/teardown.
   Function parentSetup = _testSetup;
   Function parentTeardown = _testTeardown;
 
   try {
     _testSetup = null;
     _testTeardown = null;
     body();
   } catch (e, trace) {
-    _reportTestError(e.toString(), trace == null ? '' : trace.toString());
+    var stack = (trace == null) ? '' : ': ${trace.toString()}';
+    _uncaughtErrorMessage = "${e.toString()}$stack";
   } finally {
     // Now that the group is over, restore the previous one.
     _currentGroup = parentGroup;
     _testSetup = parentSetup;
     _testTeardown = parentTeardown;
   }
 }
 
 /**
  * Register a [setUp] function for a test [group]. This function will
@@ skipping 61 matching lines @@
   _handleCallbackFunctionComplete();
 }
 
 /**
  * Utility function that can be used to notify the test framework that an
  *  error was caught outside of this library.
  */
 void _reportTestError(String msg, String trace) {
  if (_currentTest < _tests.length) {
     final testCase = _tests[_currentTest];
-    testCase.error(msg, trace);
-    if (testCase.callbackFunctionsOutstanding > 0) {
-      _nextTestCase();
+    if (testCase.running) {

[Siggi Cherem (dart-lang), 2012/09/07 19:27:37]

this part should probably go away? (seems that you reverted the change that
added .running to test case)

+      testCase.error(msg, trace);
+      if (testCase.callbackFunctionsOutstanding > 0) {
+        _nextTestCase();
+      }
+      return;
     }
-  } else {
-    _uncaughtErrorMessage = "$msg: $trace";
   }
+  _uncaughtErrorMessage = "$msg: $trace";
 }
 
 /** Runs [callback] at the end of the event loop. */
 _defer(void callback()) {
   // Exploit isolate ports as a platform-independent mechanism to queue a
   // message at the end of the event loop.
   // TODO(sigmund): expose this functionality somewhere in our libraries.
   final port = new ReceivePort();
   port.receive((msg, reply) {
     callback();
@@ skipping 182 matching lines @@
 }
 
 /** Enable a test by ID. */
 void enableTest(int testId) => _setTestEnabledState(testId, true);
 
 /** Disable a test by ID. */
 void disableTest(int testId) => _setTestEnabledState(testId, false);
 
 /** Signature for a test function. */
 typedef void TestFunction();