Convert static error to warning for calls to toplevel methods, getters and setters.

Convert static error to warning for calls to nonexisting toplevel methods, getters and setters.

This also fixes an issue with calling nonexisting static getters/setters when an abstract field was defined.

R=ngeoffray@google.com

Committed: https://code.google.com/p/dart/source/detail?r=12361

[ngeoffray, 2012-09-13 09:18:30]

LGTM

https://chromiumcodereview.appspot.com/10908236/diff/1/lib/compiler/implement...
File lib/compiler/implementation/resolver.dart (right):

https://chromiumcodereview.appspot.com/10908236/diff/1/lib/compiler/implement...
lib/compiler/implementation/resolver.dart:1300: // TODO(karlklose): this should
be reported by the caller to select
the caller of [resolveSend] ...

[ahe, 2012-09-13 11:26:39]

Comments so far.

https://chromiumcodereview.appspot.com/10908236/diff/1/tests/co19/co19-dart2j...
File tests/co19/co19-dart2js.status (right):

https://chromiumcodereview.appspot.com/10908236/diff/1/tests/co19/co19-dart2j...
tests/co19/co19-dart2js.status:639: Language/05_Variables/05_Variables_A01_t03:
Fail, OK # Issue 1031: error -> warning
Could you use the convention I have used on lines 670-758.

[karlklose, 2012-09-13 12:00:43]

Thanks, Nicolas and Peter.

https://chromiumcodereview.appspot.com/10908236/diff/1/lib/compiler/implement...
File lib/compiler/implementation/resolver.dart (right):

https://chromiumcodereview.appspot.com/10908236/diff/1/lib/compiler/implement...
lib/compiler/implementation/resolver.dart:1300: // TODO(karlklose): this should
be reported by the caller to select
On 2012/09/13 09:18:30, ngeoffray wrote:
> the caller of [resolveSend] ...

Done.

https://chromiumcodereview.appspot.com/10908236/diff/1/tests/co19/co19-dart2j...
File tests/co19/co19-dart2js.status (right):

https://chromiumcodereview.appspot.com/10908236/diff/1/tests/co19/co19-dart2j...
tests/co19/co19-dart2js.status:639: Language/05_Variables/05_Variables_A01_t03:
Fail, OK # Issue 1031: error -> warning
On 2012/09/13 11:26:39, ahe wrote:
> Could you use the convention I have used on lines 670-758.

Done.

[ahe, 2012-09-13 12:31:14]

LGTM

https://chromiumcodereview.appspot.com/10908236/diff/6002/tests/language/call...
File tests/language/call_nonexistent_static_test.dart (right):

https://chromiumcodereview.appspot.com/10908236/diff/6002/tests/language/call...
tests/language/call_nonexistent_static_test.dart:22: Expect.throws(() => D.hest
= 1, (e) => e is NoSuchMethodError); /// 04: static type warning
Line is longer than 80 columns.

Which reveals an error with this approach. The static warning, I presume is on
D.hest = 1, but there is nothing wrong with the rest of the expression.

So this is a poor test of static warnings.

[karlklose, 2012-09-13 13:47:26]

Please take another look at the test.

https://chromiumcodereview.appspot.com/10908236/diff/6002/tests/language/call...
File tests/language/call_nonexistent_static_test.dart (right):

https://chromiumcodereview.appspot.com/10908236/diff/6002/tests/language/call...
tests/language/call_nonexistent_static_test.dart:22: Expect.throws(() => D.hest
= 1, (e) => e is NoSuchMethodError); /// 04: static type warning
I changed the test.

[ahe, 2012-09-13 14:31:39]

I think that test is much better on many levels. Putting each test code in its
own top-level method may better exercise compilers.

LGTM!

[karlklose, 2012-09-14 05:42:52]

Thank you, Peter.