Convert static error to warning for calls to toplevel methods, getters and setters.

lib/compiler/implementation/resolver.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 abstract class TreeElements {
   Element operator[](Node node);
   Selector getSelector(Send send);
   DartType getType(TypeAnnotation annotation);
   bool isParameterChecked(Element element);
 }
@@ skipping 1028 matching lines @@
       return null;
     } else if (node.isSuper()) {
       if (!inInstanceContext) error(node, MessageKind.NO_SUPER_IN_STATIC);
       if ((ElementCategory.SUPER & allowedCategory) == 0) {
         error(node, MessageKind.INVALID_USE_OF_SUPER);
       }
       return null;
     } else {
       Element element = lookup(node, node.source);
       if (element === null) {
-        if (!inInstanceContext) error(node, MessageKind.CANNOT_RESOLVE, [node]);
+        if (!inInstanceContext) {
+          element = warnAndCreateErroneousElement(node, node.source,
+                                                  MessageKind.CANNOT_RESOLVE,
+                                                  [node]);
+        }
       } else {
         if ((element.kind.category & allowedCategory) == 0) {
           // TODO(ahe): Improve error message. Need UX input.
           error(node, MessageKind.GENERIC, ["is not an expression $element"]);
         }
       }
       return useElement(node, element);
     }
   }
 
@@ skipping 226 matching lines @@
       }
       target = currentClass.lookupSuperMember(name);
       // [target] may be null which means invoking noSuchMethod on
       // super.
     } else if (Elements.isUnresolved(resolvedReceiver)) {
       return null;
     } else if (resolvedReceiver.kind === ElementKind.CLASS) {
       ClassElement receiverClass = resolvedReceiver;
       target = receiverClass.ensureResolved(compiler).lookupLocalMember(name);
       if (target === null) {
+        // TODO(karlklose): this should be reported by the caller to select

[ngeoffray, 2012/09/13 09:18:30]

the caller of [resolveSend] ...

[karlklose, 2012/09/13 12:00:43]

Done.

+        // better warning messages for getters and setters.
         return warnAndCreateErroneousElement(node, name,
                                              MessageKind.METHOD_NOT_FOUND,
                                              [receiverClass.name, name]);
       } else if (target.isInstanceMember()) {
         error(node, MessageKind.MEMBER_NOT_STATIC, [receiverClass.name, name]);
       }
     } else if (resolvedReceiver.kind === ElementKind.PREFIX) {
       PrefixElement prefix = resolvedReceiver;
       target = prefix.lookupLocalMember(name);
       if (target == null) {
@@ skipping 83 matching lines @@
       }
     }
   }
 
   visitSend(Send node) {
     Element target = resolveSend(node);
     if (!Elements.isUnresolved(target)
         && target.kind == ElementKind.ABSTRACT_FIELD) {
       AbstractFieldElement field = target;
       target = field.getter;
-      if (Elements.isUnresolved(target) && !inInstanceContext) {
-        error(node.selector, MessageKind.CANNOT_RESOLVE_GETTER);
+      if (target == null && !inInstanceContext) {
+        target =
+            warnAndCreateErroneousElement(node.selector, field.name,
+                                          MessageKind.CANNOT_RESOLVE_GETTER,
+                                          [node.selector]);
       }
     }
 
     bool resolvedArguments = false;
     if (node.isOperator) {
       String operatorString = node.selector.asOperator().source.stringValue;
       if (operatorString === 'is' || operatorString === 'as') {
         assert(node.arguments.tail.isEmpty());
         DartType type = resolveTypeTest(node.arguments.head);
         if (type != null) {
@@ skipping 42 matching lines @@
     Element setter = target;
     Element getter = target;
     String source = node.assignmentOperator.source.stringValue;
     bool isComplex = source !== '=';
     if (!Elements.isUnresolved(target)
         && target.kind == ElementKind.ABSTRACT_FIELD) {
       AbstractFieldElement field = target;
       setter = field.setter;
       getter = field.getter;
       if (setter == null && !inInstanceContext) {
-        error(node.selector, MessageKind.CANNOT_RESOLVE_SETTER);
+        setter =
+            warnAndCreateErroneousElement(node.selector, field.name,
+                                          MessageKind.CANNOT_RESOLVE_SETTER,
+                                          [node.selector]);
       }
       if (isComplex && getter == null && !inInstanceContext) {
-        error(node.selector, MessageKind.CANNOT_RESOLVE_GETTER);
+        getter =
+            warnAndCreateErroneousElement(node.selector, field.name,
+                                          MessageKind.CANNOT_RESOLVE_GETTER,
+                                          [node.selector]);
       }
     }
 
     visit(node.argumentsNode);
 
     // TODO(ngeoffray): Check if the target can be assigned.
     // TODO(ngeoffray): Warn if target is null and the send is
     // unqualified.
 
     Selector selector = mapping.getSelector(node);
@@ skipping 1286 matching lines @@
 
   Element localLookup(SourceString name) => library.find(name);
   Element lookup(SourceString name) => localLookup(name);
   Element lexicalLookup(SourceString name) => localLookup(name);
 
   Element add(Element newElement) {
     throw "Cannot add an element in the top scope";
   }
   String toString() => '$element';
 }