Issue 10908038: Significant cleanup of create_sdk now that libraries have

Issue 10908038: Significant cleanup of create_sdk now that libraries have (Closed)

Created:
8 years, 3 months ago by dgrove

Modified:
8 years, 3 months ago

Reviewers:
Bob Nystrom, ahe, danrubel

CC:
reviews_dartlang.org, compiler-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Significant cleanup of create_sdk now that libraries have been unified. - Remove separate copy of libs in SDK for dart2js - Make html library structure match in SDK and repo Committed: https://code.google.com/p/dart/source/detail?r=11732

Patch Set 1 #

Patch Set 2 : #

Total comments: 5

Patch Set 3 : #

Patch Set 4 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -131 lines)			Patch
M	lib/_internal/libraries.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/config/import_any.config	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/create_sdk.py	View	1 2 3	7 chunks	+22 lines, -129 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

danrubel

LGTM with one change noted below... https://chromiumcodereview.appspot.com/10908038/diff/3001/tools/create_sdk.py File tools/create_sdk.py (left): https://chromiumcodereview.appspot.com/10908038/diff/3001/tools/create_sdk.py#oldcode373 tools/create_sdk.py:373: # Copy import ...

8 years, 3 months ago (2012-08-31 17:27:51 UTC) #2

Bob Nystrom

This is wonderful. One question, but otherwise LGTM. https://chromiumcodereview.appspot.com/10908038/diff/3001/tools/create_sdk.py File tools/create_sdk.py (right): https://chromiumcodereview.appspot.com/10908038/diff/3001/tools/create_sdk.py#newcode234 tools/create_sdk.py:234: ignore=ignore_patterns('*.svn', ...

8 years, 3 months ago (2012-08-31 17:52:31 UTC) #3

dgrove

PTAL - a few other minor cleanups, plus questions answered. https://chromiumcodereview.appspot.com/10908038/diff/3001/tools/create_sdk.py File tools/create_sdk.py (left): https://chromiumcodereview.appspot.com/10908038/diff/3001/tools/create_sdk.py#oldcode373 ...

8 years, 3 months ago (2012-08-31 18:25:41 UTC) #4

danrubel

8 years, 3 months ago (2012-08-31 19:24:52 UTC) #5

https://chromiumcodereview.appspot.com/10908038/diff/3001/tools/create_sdk.py
File tools/create_sdk.py (left):

https://chromiumcodereview.appspot.com/10908038/diff/3001/tools/create_sdk.py...
tools/create_sdk.py:373: # Copy import maps.
On 2012/08/31 18:25:42, dgrove wrote:
> On 2012/08/31 17:27:51, danrubel wrote:
> > We still need this section in there for a little while longer.
> 
> config is actually being copied in line 218. Turns out that what's currently
> here is overkill.

Good by me!

Expand Messages | Collapse Messages