Significant cleanup of create_sdk now that libraries have

tools/create_sdk.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 #
 # A script which will be invoked from gyp to create an SDK.
 #
 # Usage: create_sdk.py sdk_directory
 #
 # The SDK will be used either from the command-line or from the editor.
 # Top structure is
 #
 # ..dart-sdk/
 # ....bin/
 # ......dart or dart.exe (executable)
 # ......dart.lib (import library for VM native extensions on Windows)
 # ......dart2js
 # ......dart_analyzer
 # ......pub
 # ....include/
 # ......dart_api.h
 # ......dart_debugger_api.h
 # ....lib/
-# ......builtin/
-# ........builtin_runtime.dart
+# ......_internal/
+# ......compiler/
+# ......config/
+# ......core/
+# ......coreimpl/
+# ......crypto/
+# ......html/
 # ......io/
-# ........io_runtime.dart
-# ........runtime/
-# ......compiler/
-# ......core/
-# ........core_runtime.dart
-# ........runtime/
-# ......coreimpl/
-# ........coreimpl_runtime.dart
-# ........runtime/
-# ......dart2js/
 # ......isolate/
-# ........isolate_{dart2js, runtime}.dart
-# ........dart2js/
-# ......dom/
-# ........dom.dart
-# ......html/
-# ........html_dart2js.dart
-# ........html_dartium.dart
-# ......crypto/
-# ........crypto.dart
-# ........(implementation files)
 # ......json/
-# ........json_frog.dart
-#.........json.dart
-# ........{frog}/
+# ......math/
 # ......mirrors/
-# ........mirrors.dart
 # ......uri/
-# ........uri.dart
 # ......utf/
 # ......web/
-# ........web.dart
 # ....pkg/
 # ......args/
 # ......dartdoc/
 # ......intl/
 # ......logging/
+# ......unittest/
 # ......(more will come here)
 # ....util/
 # ......analyzer/
 # ........dart_analyzer.jar
 # ........(third-party libraries for dart_analyzer)
 # ......pub/
 # ......(more will come here)
 
 
 
@@ skipping 39 matching lines @@
   file_extension = ''
   if utils.GuessOS() == 'win32':
     file_extension = '.bat'
 
   src = src_file + file_extension
   dest = join(dest_dir, basename(src_file) + file_extension)
   Copy(src, dest)
 
 
 def CopyDart2Js(build_dir, sdk_root):
-  '''
-  Install dart2js in SDK/lib/dart2js.
-
-  Currently, we copy too much stuff to this location, but the SDK's
-  layout matches the the layout of the part of the repository we're
-  dealing with here which frees us from rewriting files. The long term
-  plan is to align the layout of the repository and the SDK, at which
-  point we should be able to simplify Main below and share the dart
-  files between the various components to minimize SDK download size.
-  '''
-  copytree('lib', os.path.join(sdk_root, 'lib', 'dart2js', 'lib'),
-           ignore=ignore_patterns('.svn'))
-  copytree(os.path.join('runtime', 'lib'),
-           os.path.join(sdk_root, 'lib', 'dart2js', 'runtime', 'lib'),
-           ignore=ignore_patterns('.svn'))
-  copytree(os.path.join('runtime', 'bin'),
-           os.path.join(sdk_root, 'lib', 'dart2js', 'runtime', 'bin'),
-           ignore=ignore_patterns('.svn'))
   if utils.GuessOS() == 'win32':
     dart2js = os.path.join(sdk_root, 'bin', 'dart2js.bat')
     Copy(os.path.join(build_dir, 'dart2js.bat'), dart2js)
     ReplaceInFiles([dart2js],
                    [(r'%SCRIPTPATH%\.\.\\lib',
-                     r'%SCRIPTPATH%..\lib\dart2js\lib')])
+                     r'%SCRIPTPATH%..\lib')])
     dartdoc = os.path.join(sdk_root, 'bin', 'dartdoc.bat')
     Copy(os.path.join(build_dir, 'dartdoc.bat'), dartdoc)
   else:
     dart2js = os.path.join(sdk_root, 'bin', 'dart2js')
     Copy(os.path.join(build_dir, 'dart2js'), dart2js)
     ReplaceInFiles([dart2js],
                    [(r'\$BIN_DIR/\.\./\.\./lib',
-                     r'$BIN_DIR/../lib/dart2js/lib')])
+                     r'$BIN_DIR/../lib')])
     dartdoc = os.path.join(sdk_root, 'bin', 'dartdoc')
     Copy(os.path.join(build_dir, 'dartdoc'), dartdoc)
 
 
 def Main(argv):
   # Pull in all of the gpyi files which will be munged into the sdk.
   io_runtime_sources = \
     (eval(open("runtime/bin/io_sources.gypi").read()))['sources']
 
   HOME = dirname(dirname(realpath(__file__)))
@@ skipping 76 matching lines @@
   # Construct lib/io/io_runtime.dart from whole cloth.
   dest_file = open(join(io_dest_dir, 'io_runtime.dart'), 'a')
   for filename in io_runtime_sources:
     assert filename.endswith('.dart')
     if filename == 'io.dart':
       continue
     dest_file.write('#source("runtime/' + filename + '");\n')
   dest_file.close()
 
   #
-  # Create and populate lib/compiler.
-  #
-  compiler_src_dir = join(HOME, 'lib', 'compiler')
-  compiler_dest_dir = join(LIB, 'compiler')
-
-  copytree(compiler_src_dir, compiler_dest_dir, ignore=ignore_patterns('.svn'))
-
-  # Remap imports in lib/compiler/* .
-  for (dirpath, subdirs, filenames) in os.walk(compiler_dest_dir):
-    for filename in filenames:
-      if filename.endswith('.dart'):
-        filename = join(dirpath, filename)
-        file_contents = open(filename).read()
-        file = open(filename, 'w')
-        file_contents = re.sub(r"\.\./lib", "..", file_contents)
-        file.write(file_contents)
-        file.close()
-
-  #
-  # Create and populate lib/html.
-  #
-  html_src_dir = join(HOME, 'lib', 'html')
-  html_dest_dir = join(LIB, 'html')
-  os.makedirs(html_dest_dir)
-
-  copyfile(join(html_src_dir, 'dart2js', 'html_dart2js.dart'),
-           join(html_dest_dir, 'html_dart2js.dart'))
-  copyfile(join(html_src_dir, 'dartium', 'html_dartium.dart'),
-           join(html_dest_dir, 'html_dartium.dart'))
-  copyfile(join(html_src_dir, 'dartium', 'nativewrappers.dart'),
-           join(html_dest_dir, 'nativewrappers.dart'))
-
-  #
-  # Create and populate lib/dom.
-  #
-  dom_src_dir = join(HOME, 'lib', 'dom')
-  dom_dest_dir = join(LIB, 'dom')
-  os.makedirs(dom_dest_dir)
-
-  copyfile(join(dom_src_dir, 'dart2js', 'dom_dart2js.dart'),
-           join(dom_dest_dir, 'dom_dart2js.dart'))
-
-  #
   # Create and populate lib/{core, crypto, isolate, json, uri, utf, ...}.
   #
 
-  for library in ['_internal', 'core', 'coreimpl', 'crypto', 'isolate', 'json',
-                  'math', 'mirrors', 'uri', 'utf', 'web']:
-    src_dir = join(HOME, 'lib', library)
-    dest_dir = join(LIB, library)
-    os.makedirs(dest_dir)
-
-    for filename in os.listdir(src_dir):
-      if filename.endswith('.dart'):
-        copyfile(join(src_dir, filename), join(dest_dir, filename))
+  for library in ['_internal', 'compiler', 'config', 'html', 'core', 'coreimpl',
+                  'crypto', 'isolate', 'json', 'math', 'mirrors', 'uri', 'utf',
+                  'web']:
+    copytree(join(HOME, 'lib', library), join(LIB, library),
+             ignore=ignore_patterns('*.svn', 'doc', '*.py', '*.gypi', '*.sh'))
 
   # Create and copy pkg.
   PKG = join(SDK_tmp, 'pkg')
   os.makedirs(PKG)
 
   #
   # Create and populate pkg/{args, intl, logging, unittest}
   #
 
   for library in ['args', 'intl', 'logging', 'unittest']:
-    src_dir = join(HOME, 'pkg', library)
-    dest_dir = join(PKG, library)
-    os.makedirs(dest_dir)
-
-    for filename in os.listdir(src_dir):
-      if filename.endswith('.dart'):
-        copyfile(join(src_dir, filename), join(dest_dir, filename))
-    if exists(join(src_dir, 'lib')):
-      copytree(join(src_dir, 'lib'), join(dest_dir, 'lib'),
-           ignore=ignore_patterns('.svn'))
+    copytree(join(HOME, 'pkg', library), join(PKG, library),
+             ignore=ignore_patterns('*.svn', 'doc', '*.py', '*.gypi', '*.sh'))

[Bob Nystrom, 2012/08/31 17:52:31]

This means we'll be including each package's tests in the SDK, right? Is that
intended?

[dgrove, 2012/08/31 18:25:42]

For now, that's intended. We can pull them out before M1 if we think it's
important.

 
   # Create and populate pkg/dartdoc.
   dartdoc_src_dir = join(HOME, 'pkg', 'dartdoc')
   dartdoc_dest_dir = join(PKG, 'dartdoc')
   copytree(dartdoc_src_dir, dartdoc_dest_dir,
            ignore=ignore_patterns('.svn', 'docs'))
 
   # Fixup dart2js dependencies.
   ReplaceInFiles([
       join(PKG, 'dartdoc', 'dartdoc.dart'),
@@ skipping 26 matching lines @@
         dest_file = join (ANALYZER_DEST, jarToCopy)
         src_file = join(ANALYZER_HOME, 'util', 'analyzer', jarToCopy)
         copyfile(src_file, dest_file)
 
   # Create and populate util/pub.
   pub_src_dir = join(HOME, 'utils', 'pub')
   pub_dst_dir = join(UTIL, 'pub')
   copytree(pub_src_dir, pub_dst_dir,
            ignore=ignore_patterns('.svn', 'sdk'))
 
-  # Copy import maps.

[danrubel, 2012/08/31 17:27:51]

We still need this section in there for a little while longer.

[dgrove, 2012/08/31 18:25:42]

config is actually being copied in line 218. Turns out that what's currently
here is overkill.

[danrubel, 2012/08/31 19:24:52]

Good by me!

-  PLATFORMS = ['any', 'vm', 'dartium', 'dart2js' ]
-  os.makedirs(join(LIB, 'config'))
-  for platform in PLATFORMS:
-    import_src = join(HOME, 'lib', 'config', 'import_' + platform + '.config')
-    import_dst = join(LIB, 'config', 'import_' + platform + '.config')
-    copyfile(import_src, import_dst);
-
   # Copy dart2js.
   CopyDart2Js(build_dir, SDK_tmp)
 
   # Write the 'revision' file
   revision = utils.GetSVNRevision()
   if revision is not None:
     with open(os.path.join(SDK_tmp, 'revision'), 'w') as f:
       f.write(revision + '\n')
       f.close()
 
   move(SDK_tmp, SDK)
   utils.Touch(os.path.join(SDK, 'create.stamp'))
 
 if __name__ == '__main__':
   sys.exit(Main(sys.argv))