Issue 10908005: Reapply revision 11570, custom callbacks are now implemented in dartium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10908005: Reapply revision 11570, custom callbacks are now implemented in dartium. (Closed)

Created:
8 years, 3 months ago by podivilov

Modified:
8 years, 3 months ago

Reviewers:
ricow1, Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reapply revision 11570, custom callbacks are now implemented in dartium. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=11588

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+266 lines, -59 lines)			Patch
M	lib/compiler/implementation/lib/native_helper.dart	View	4 chunks	+5 lines, -0 lines	0 comments	Download
M	lib/dom/dart2js/dom_dart2js.dart	View	3 chunks	+20 lines, -1 line	0 comments	Download
M	lib/dom/dom.dart	View	2 chunks	+10 lines, -1 line	0 comments	Download
M	lib/dom/idl/dart/dart.idl	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	lib/dom/scripts/htmlrenamer.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/dom/scripts/systemhtml.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/dom/src/dart2js_FactoryProviders.dart	View	1 chunk	+9 lines, -0 lines	0 comments	Download
A +	lib/dom/templates/html/dart2js/factoryprovider_FormData.darttemplate	View	1 chunk	+4 lines, -5 lines	0 comments	Download
M	lib/html/dart2js/html_dart2js.dart	View	6 chunks	+37 lines, -18 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View	4 chunks	+31 lines, -14 lines	0 comments	Download
M	lib/html/doc/html.dartdoc	View	2 chunks	+1 line, -1 line	0 comments	Download
D	lib/html/doc/interface/DOMFormData.dartdoc	View	1 chunk	+0 lines, -14 lines	0 comments	Download
A +	lib/html/doc/interface/FormData.dartdoc	View	1 chunk	+1 line, -1 line	0 comments	Download
A	tests/html/form_data_test.dart	View	1 chunk	+36 lines, -0 lines	0 comments	Download
A	tests/html/form_element_test.dart	View	1 chunk	+83 lines, -0 lines	0 comments	Download
M	tests/html/html.status	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/testing/perf_testing/run_perf_tests.py	View	6 chunks	+16 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ricow1

Rubberstamp LGTM, I assume that there are no actual code changes compared to 11570, just ...

8 years, 3 months ago (2012-08-30 09:01:19 UTC) #2

Emily Fortuna

8 years, 3 months ago (2012-08-30 17:22:54 UTC) #3

many thanks. For reference, what was the CL in Dartium that you submitted to fix
the issue?

Expand Messages | Collapse Messages