Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: tools/testing/perf_testing/run_perf_tests.py

Issue 10908005: Reapply revision 11570, custom callbacks are now implemented in dartium. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/html/html.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/perf_testing/run_perf_tests.py
diff --git a/tools/testing/perf_testing/run_perf_tests.py b/tools/testing/perf_testing/run_perf_tests.py
index 7255e6d4b9c3cb85ca55e7a110d37230f7d57abc..f5a0eb902d16a4d84577573c917f48767feded8d 100755
--- a/tools/testing/perf_testing/run_perf_tests.py
+++ b/tools/testing/perf_testing/run_perf_tests.py
@@ -98,6 +98,8 @@ class TestRunner(object):
shutil.rmtree(to_remove)#, ignore_errors=True)
else:
os.remove(to_remove)
+ elif any(line.startswith(status) for status in ['A', 'M', 'C', 'D']):
+ self.RunCmd(['svn', 'revert', line.split()[1]])
def GetArchive(self, archive_name):
"""Wrapper around the pulling down a specific archive from Google Storage.
@@ -249,8 +251,15 @@ class TestRunner(object):
return (HasPerfAffectingResults(GetFileList(
revision_num)), revision_num)
else:
- results, _ = self.RunCmd(['svn', 'st', '-u'], std_in='p\r\n')
- latest_interesting_server_rev = int(results.split('\n')[-2].split()[-1])
+ latest_interesting_server_rev = None
+ while not latest_interesting_server_rev:
+ results, _ = self.RunCmd(['svn', 'st', '-u'], std_in='p\r\n')
+ if len(results.split('\n')) >= 2:
+ latest_interesting_server_rev = int(
+ results.split('\n')[-2].split()[-1])
+ print 'success'
+ else:
+ print 'hrmmmm'
if self.backfill:
done_cls = list(UpdateSetOfDoneCls())
done_cls.sort()
@@ -413,6 +422,8 @@ class Test(object):
"""
# TODO(vsm): This avoids a bug in 32-bit Chrome (dartium)
# running JS dromaeo.
+ if variant == 'js':
+ return False
if platform == 'dartium' and variant == 'js':
return False
if (platform == 'safari' and variant == 'dart2js' and
@@ -654,6 +665,7 @@ class CommonBrowserTest(RuntimePerformanceTest):
"""Comb through the html to find the performance results.
Returns: True if we successfully posted our data to storage and/or we can
delete the trace file."""
+ print afile
os.chdir(os.path.join(TOP_LEVEL_DIR, 'tools',
'testing', 'perf_testing'))
parts = afile.split('-')
@@ -911,6 +923,7 @@ class DromaeoTest(RuntimePerformanceTest):
def ProcessFile(self, afile, should_post_file):
"""Comb through the html to find the performance results.
Returns: True if we successfully posted our data to storage."""
+ print afile
parts = afile.split('-')
browser = parts[2]
version = parts[3]
@@ -927,7 +940,7 @@ class DromaeoTest(RuntimePerformanceTest):
upload_success = True
for line in lines:
- rev = re.match(revision_pattern, line.strip())
+ rev = re.match(revision_pattern, line.strip().replace('"', ''))
if rev:
revision_num = int(rev.group(1))
continue
« no previous file with comments | « tests/html/html.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698