Issue 10907015: Include build ID in dart2js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10907015: Include build ID in dart2js (Closed)

Created:
8 years, 3 months ago by ahe

Modified:
8 years, 3 months ago

Reviewers:
dgrove

CC:
reviews_dartlang.org, kasperl

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Include build ID in dart2js Committed: https://code.google.com/p/dart/source/detail?r=11678

Patch Set 2 : Update comment #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -9 lines)			Patch
M	dart/lib/compiler/implementation/compiler.dart	View	1	3 chunks	+13 lines, -3 lines	0 comments	Download
M	dart/lib/compiler/implementation/dart2js.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	dart/tools/create_sdk.py	View		3 chunks	+11 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ahe

https://chromiumcodereview.appspot.com/10907015/diff/1/dart/lib/compiler/implementation/compiler.dart File dart/lib/compiler/implementation/compiler.dart (right): https://chromiumcodereview.appspot.com/10907015/diff/1/dart/lib/compiler/implementation/compiler.dart#newcode17 dart/lib/compiler/implementation/compiler.dart:17: /** I forgot to add a comment here.

8 years, 3 months ago (2012-08-30 23:00:46 UTC) #3

ahe

Hi Dan, Thank you for the quick review. I updated the comment, and will be ...

8 years, 3 months ago (2012-08-31 09:29:30 UTC) #4

dgrove

8 years, 3 months ago (2012-08-31 14:50:31 UTC) #5

On 2012/08/31 09:29:30, ahe wrote:
> Hi Dan,
> 
> Thank you for the quick review.
> 
> I updated the comment, and will be submitting.
> 
> It would be great if you could proof-read the comment.
> 
> Cheers,
> Peter

LGTM  - This looks perfect. Thanks Peter.

Expand Messages | Collapse Messages

Issue 10907015: Include build ID in dart2js (Closed)

Description

Patch Set 1 #

Patch Set 2 : Update comment #

Messages