Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: dart/lib/compiler/implementation/compiler.dart

Issue 10907015: Include build ID in dart2js (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Update comment Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dart/lib/compiler/implementation/dart2js.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/lib/compiler/implementation/compiler.dart
diff --git a/dart/lib/compiler/implementation/compiler.dart b/dart/lib/compiler/implementation/compiler.dart
index 199712912055aedb88a62c36fc2a508c627dea22..f22184e30d276639fb1c1936d6f9042114e7f6fe 100644
--- a/dart/lib/compiler/implementation/compiler.dart
+++ b/dart/lib/compiler/implementation/compiler.dart
@@ -15,6 +15,17 @@ const bool REPORT_EXCESS_RESOLUTION = false;
const bool REPORT_PASS2_OPTIMIZATIONS = false;
/**
+ * A string to identify the revision or build.
+ *
+ * This ID is displayed if the compiler crashes and in verbose mode, and is
+ * an aid in reproducing bug reports.
+ *
+ * The actual string is rewritten during the SDK build process.
+ */
+const String BUILD_ID = 'build number could not be determined';
+
+
+/**
* Contains backend-specific data that is used throughout the compilation of
* one work item.
*/
@@ -229,9 +240,7 @@ class Compiler implements DiagnosticListener {
reportDiagnostic(spanFromElement(element),
MessageKind.COMPILER_CRASHED.error().toString(),
api.Diagnostic.CRASH);
- // TODO(ahe): Obtain the build ID.
- var buildId = 'build number could not be determined';
- print(MessageKind.PLEASE_REPORT_THE_CRASH.message([buildId]));
+ print(MessageKind.PLEASE_REPORT_THE_CRASH.message([BUILD_ID]));
}
void cancel([String reason, Node node, Token token,
@@ -522,6 +531,7 @@ class Compiler implements DiagnosticListener {
}
void runCompiler(Uri uri) {
+ log('compiling $uri ($BUILD_ID)');
scanBuiltinLibraries();
mainApp = scanner.loadLibrary(uri, null, uri);
libraries.forEach((_, library) {
« no previous file with comments | « no previous file | dart/lib/compiler/implementation/dart2js.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698