Issue 10905010: Some code cleanups in arrays, fix rangeCheck (issue 2899).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10905010: Some code cleanups in arrays, fix rangeCheck (issue 2899). (Closed)

Created:
8 years, 3 months ago by srdjan

Modified:
8 years, 3 months ago

Reviewers:
Bill Hesse

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Some code cleanups in arrays, fix rangeCheck (issue 2899). Committed: https://code.google.com/p/dart/source/detail?r=11572

Patch Set 6 : #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -10 lines)			Patch
M	corelib/src/implementation/arrays.dart	View	1	1 chunk	+2 lines, -2 lines	2 comments	Download
M	runtime/lib/array.dart	View	1 2 5	3 chunks	+3 lines, -5 lines	0 comments	Download
M	runtime/lib/growable_array.dart	View	1 2 3 4 5	2 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

http://codereview.chromium.org/10905010/diff/10001/corelib/src/implementation/arrays.dart File corelib/src/implementation/arrays.dart (right): http://codereview.chromium.org/10905010/diff/10001/corelib/src/implementation/arrays.dart#newcode84 corelib/src/implementation/arrays.dart:84: String message = "$start must be greater equal to ...

8 years, 3 months ago (2012-09-06 16:19:43 UTC) #3

srdjan

8 years, 3 months ago (2012-09-07 13:19:08 UTC) #4

Thanks.

http://codereview.chromium.org/10905010/diff/10001/corelib/src/implementation...
File corelib/src/implementation/arrays.dart (right):

http://codereview.chromium.org/10905010/diff/10001/corelib/src/implementation...
corelib/src/implementation/arrays.dart:84: String message = "$start must be
greater equal to 0";
On 2012/09/06 16:19:43, Bill Hesse wrote:
> greater than or equal to

Fixed in next CL.

Expand Messages | Collapse Messages

Issue 10905010: Some code cleanups in arrays, fix rangeCheck (issue 2899). (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Messages