Some code cleanups in arrays, fix rangeCheck (issue 2899).

runtime/lib/array.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 
 // TODO(srdjan): Use shared array implementation.
 class ObjectArray<E> implements List<E> {
 
   factory ObjectArray(int length) native "ObjectArray_allocate";
 
@@ skipping 30 matching lines @@
   }
 
   void insertRange(int start, int length, [E initialValue = null]) {
     throw const UnsupportedOperationException(
         "Cannot insert range in a non-extendable array");
   }
 
   List<E> getRange(int start, int length) {
     if (length == 0) return [];
     Arrays.rangeCheck(this, start, length);
-    List list = new List<E>();
+    List list = new GrowableObjectArray<E>.withCapacity(length);
     list.length = length;
     Arrays.copy(this, start, list, 0, length);
     return list;
   }
 
   /**
    * Collection interface.
    */
 
   void forEach(f(E element)) {
     Collections.forEach(this, f);
   }
 
   Collection map(f(E element)) {
     return Collections.map(this, new GrowableObjectArray.withCapacity(length), f);
   }
 
-  Dynamic reduce(Dynamic initialValue,
-                 Dynamic combine(Dynamic previousValue, E element)) {
+  reduce(initialValue, combine(previousValue, E element)) {
     return Collections.reduce(this, initialValue, combine);
   }
 
   Collection<E> filter(bool f(E element)) {
     return Collections.filter(this, new GrowableObjectArray<E>(), f);
   }
 
   bool every(bool f(E element)) {
     return Collections.every(this, f);
   }
@@ skipping 115 matching lines @@
    */
 
   void forEach(f(E element)) {
     Collections.forEach(this, f);
   }
 
   Collection map(f(E element)) {
     return Collections.map(this, new GrowableObjectArray.withCapacity(length), f);
   }
 
-  Dynamic reduce(Dynamic initialValue,
-                 Dynamic combine(Dynamic previousValue, E element)) {
+  reduce(initialValue, combine(previousValue, E element)) {
     return Collections.reduce(this, initialValue, combine);
   }
 
   Collection<E> filter(bool f(E element)) {
     return Collections.filter(this, new GrowableObjectArray<E>(), f);
   }
 
   bool every(bool f(E element)) {
     return Collections.every(this, f);
   }
@@ skipping 78 matching lines @@
     if (!hasNext()) {
       throw const NoMoreElementsException();
     }
     return _array[_pos++];
   }
 
   final List<E> _array;
   final int _length;  // Cache array length for faster access.
   int _pos;
 }