Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 10902002: Remove inclusion of 'include/dart_api.h' in 'raw_object.h' (Closed)

Created:
8 years, 3 months ago by siva
Modified:
8 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove inclusion of 'include/dart_api.h' in 'raw_object.h' Committed: https://code.google.com/p/dart/source/detail?r=11571

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -36 lines) Patch
M runtime/vm/dart_api_impl.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 2 2 chunks +31 lines, -31 lines 0 comments Download
M runtime/vm/raw_object.h View 1 2 4 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
siva
8 years, 3 months ago (2012-08-29 21:05:53 UTC) #1
turnidge
lgtm
8 years, 3 months ago (2012-08-29 21:08:17 UTC) #2
Tom Ball
lgtm lgtm
8 years, 3 months ago (2012-08-29 21:13:25 UTC) #3
siva
Made the change of moving the new ExternStringGetPeerHelper function to Api class per offline discussion.
8 years, 3 months ago (2012-08-29 23:21:51 UTC) #4
Ivan Posva
LGTM -ip
8 years, 3 months ago (2012-08-30 00:04:07 UTC) #5
Tom Ball
8 years, 3 months ago (2012-08-30 00:06:53 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698