Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 10902002: Remove inclusion of 'include/dart_api.h' in 'raw_object.h' (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl.h ('k') | runtime/vm/raw_object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl.cc
===================================================================
--- runtime/vm/dart_api_impl.cc (revision 11549)
+++ runtime/vm/dart_api_impl.cc (working copy)
@@ -254,6 +254,36 @@
}
+bool Api::ExternalStringGetPeerHelper(Dart_Handle object, void** peer) {
+ NoGCScope no_gc_scope;
+ RawObject* raw_obj = Api::UnwrapHandle(object);
+ switch (Api::ClassId(object)) {
+ case kExternalOneByteStringCid: {
+ RawExternalOneByteString* raw_string =
+ reinterpret_cast<RawExternalOneByteString*>(raw_obj)->ptr();
+ ExternalStringData<uint8_t>* data = raw_string->external_data_;
+ *peer = data->peer();
+ return true;
+ }
+ case kExternalTwoByteStringCid: {
+ RawExternalTwoByteString* raw_string =
+ reinterpret_cast<RawExternalTwoByteString*>(raw_obj)->ptr();
+ ExternalStringData<uint16_t>* data = raw_string->external_data_;
+ *peer = data->peer();
+ return true;
+ }
+ case kExternalFourByteStringCid: {
+ RawExternalFourByteString* raw_string =
+ reinterpret_cast<RawExternalFourByteString*>(raw_obj)->ptr();
+ ExternalStringData<uint32_t>* data = raw_string->external_data_;
+ *peer = data->peer();
+ return true;
+ }
+ }
+ return false;
+}
+
+
// --- Handles ---
@@ -1526,43 +1556,13 @@
}
-bool ExternalStringGetPeerHelper(Dart_Handle object, void** peer) {
- NoGCScope no_gc_scope;
- RawObject* raw_obj = Api::UnwrapHandle(object);
- switch (Api::ClassId(object)) {
- case kExternalOneByteStringCid: {
- RawExternalOneByteString* raw_string =
- reinterpret_cast<RawExternalOneByteString*>(raw_obj)->ptr();
- ExternalStringData<uint8_t>* data = raw_string->external_data_;
- *peer = data->peer();
- return true;
- }
- case kExternalTwoByteStringCid: {
- RawExternalTwoByteString* raw_string =
- reinterpret_cast<RawExternalTwoByteString*>(raw_obj)->ptr();
- ExternalStringData<uint16_t>* data = raw_string->external_data_;
- *peer = data->peer();
- return true;
- }
- case kExternalFourByteStringCid: {
- RawExternalFourByteString* raw_string =
- reinterpret_cast<RawExternalFourByteString*>(raw_obj)->ptr();
- ExternalStringData<uint32_t>* data = raw_string->external_data_;
- *peer = data->peer();
- return true;
- }
- }
- return false;
-}
-
-
DART_EXPORT Dart_Handle Dart_ExternalStringGetPeer(Dart_Handle object,
void** peer) {
if (peer == NULL) {
RETURN_NULL_ERROR(peer);
}
- if (ExternalStringGetPeerHelper(object, peer)) {
+ if (Api::ExternalStringGetPeerHelper(object, peer)) {
return Api::Success(Isolate::Current());
}
« no previous file with comments | « runtime/vm/dart_api_impl.h ('k') | runtime/vm/raw_object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698