Issue 10892037: Stop attaching try_index to individual instructions put it at block entry instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10892037: Stop attaching try_index to individual instructions put it at block entry instead. (Closed)

Created:
8 years, 3 months ago by Vyacheslav Egorov (Google)

Modified:
8 years, 3 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Stop attaching try_index to individual instructions put it at block entry instead. This simplifies code motion and insertion of instructions that make calls after graph is constructed. R=srdjan@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=11528

Patch Set 1 #

Total comments: 1

Patch Set 2 : address Srdjan's comment, make meaning of CatchTryIndex clear #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+185 lines, -363 lines)			Patch
M	runtime/vm/flow_graph_builder.cc	View		52 chunks	+85 lines, -81 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View		7 chunks	+5 lines, -9 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.h	View		7 chunks	+8 lines, -11 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View		11 chunks	+9 lines, -26 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.h	View		7 chunks	+8 lines, -11 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View		11 chunks	+7 lines, -20 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1	63 chunks	+35 lines, -105 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1	9 chunks	+5 lines, -12 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View		31 chunks	+9 lines, -44 lines	0 comments	Download
M	runtime/vm/intermediate_language_test.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View		32 chunks	+8 lines, -39 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

srdjan

8 years, 3 months ago (2012-08-29 15:53:03 UTC) #2

LGTM with comment

https://chromiumcodereview.appspot.com/10892037/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10892037/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.h:2710: bool HasCatchTryIndex() const {
Why CatchTry instead of TryCatch which seems the more conventional name?

Expand Messages | Collapse Messages