Issue 10891025: Eliminate class UseVal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10891025: Eliminate class UseVal. (Closed)

Created:
8 years, 3 months ago by Kevin Millikin (Google)

Modified:
8 years, 3 months ago

Reviewers:
Florian Schneider, srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Eliminate class UseVal. This was the only subclass of Value. All functionality is moved to the base class, and all functions are made non-virtual. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=11590

Patch Set 1 #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+146 lines, -269 lines)			Patch
M	runtime/vm/deopt_instructions.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph.cc	View	13 chunks	+19 lines, -29 lines	0 comments	Download
M	runtime/vm/flow_graph_allocator.cc	View	9 chunks	+21 lines, -35 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.h	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	12 chunks	+24 lines, -28 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	2 chunks	+5 lines, -7 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	10 chunks	+43 lines, -118 lines	1 comment	Download
M	runtime/vm/intermediate_language.cc	View	11 chunks	+26 lines, -35 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_test.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

8 years, 3 months ago (2012-08-29 19:45:53 UTC) #3

Nice! DBC.

https://chromiumcodereview.appspot.com/10891025/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10891025/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.h:118: class Definition;
One Definition too much.

Expand Messages | Collapse Messages