Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: runtime/vm/flow_graph_builder.h

Issue 10891025: Eliminate class UseVal. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_builder.h
diff --git a/runtime/vm/flow_graph_builder.h b/runtime/vm/flow_graph_builder.h
index 3efa3b30cc39dfb4d7155539b02d6629bbafe723..3f39aad6ba567c4d1c22b5f68d44f070c9fae716 100644
--- a/runtime/vm/flow_graph_builder.h
+++ b/runtime/vm/flow_graph_builder.h
@@ -108,7 +108,7 @@ class EffectGraphVisitor : public AstNodeVisitor {
// Append a graph fragment to this graph. Assumes this graph is open.
void Append(const EffectGraphVisitor& other_fragment);
// Append a computation with one use. Assumes this graph is open.
- UseVal* Bind(Computation* computation);
+ Value* Bind(Computation* computation);
// Append a computation with no uses. Assumes this graph is open.
void Do(Computation* computation);
// Append a single (non-Definition, non-Entry) instruction. Assumes this
@@ -280,10 +280,7 @@ class ValueGraphVisitor : public EffectGraphVisitor {
private:
// Helper to set the output state to return a Value.
- virtual void ReturnValue(Value* value) {
- ASSERT(value->IsUse());
- value_ = value;
- }
+ virtual void ReturnValue(Value* value) { value_ = value; }
// Specify a computation as the final result. Adds a Bind instruction to
// the graph and returns its temporary value (i.e., set the output

Powered by Google App Engine
This is Rietveld 408576698