Unify String.

Unify String.


BUG=

Committed: https://code.google.com/p/dart/source/detail?r=11380

[Mads Ager (google), 2012-08-27 10:52:00]

https://chromiumcodereview.appspot.com/10883052/diff/3001/corelib/src/string....
File corelib/src/string.dart (right):

https://chromiumcodereview.appspot.com/10883052/diff/3001/corelib/src/string....
corelib/src/string.dart:11: interface String extends Comparable, Hashable,
Pattern default
I think we should reformat this somehow. I don't find this that readable.

https://chromiumcodereview.appspot.com/10883052/diff/3001/corelib/src/strings...
File corelib/src/strings.dart (right):

https://chromiumcodereview.appspot.com/10883052/diff/3001/corelib/src/strings...
corelib/src/strings.dart:5: class Strings {
How about the remaining two methods in this class? We should move them to
StringImplementation as well and use patching for them, right?

[Anders Johnsen, 2012-08-27 12:12:42]

PTAL

https://chromiumcodereview.appspot.com/10883052/diff/3001/corelib/src/string....
File corelib/src/string.dart (right):

https://chromiumcodereview.appspot.com/10883052/diff/3001/corelib/src/string....
corelib/src/string.dart:11: interface String extends Comparable, Hashable,
Pattern default
On 2012/08/27 10:52:00, Mads Ager wrote:
> I think we should reformat this somehow. I don't find this that readable.

Like so?

https://chromiumcodereview.appspot.com/10883052/diff/3001/corelib/src/strings...
File corelib/src/strings.dart (right):

https://chromiumcodereview.appspot.com/10883052/diff/3001/corelib/src/strings...
corelib/src/strings.dart:5: class Strings {
On 2012/08/27 10:52:00, Mads Ager wrote:
> How about the remaining two methods in this class? We should move them to
> StringImplementation as well and use patching for them, right?

Right, now handled.

[Mads Ager (google), 2012-08-27 12:17:07]

This is looking good, but could you upload the VM patch file?

https://chromiumcodereview.appspot.com/10883052/diff/1002/corelib/src/string....
File corelib/src/string.dart (right):

https://chromiumcodereview.appspot.com/10883052/diff/1002/corelib/src/string....
corelib/src/string.dart:11: interface String extends Comparable,
How about:

interface String
    extends Comparable, Hashable, Pattern default StringImplementation {

or

interface String
    extends Comparable, Hashable, Pattern
    default StringImplementation {

?

[Anders Johnsen, 2012-08-27 12:20:35]

Oh, sorry, here!

https://chromiumcodereview.appspot.com/10883052/diff/1002/corelib/src/string....
File corelib/src/string.dart (right):

https://chromiumcodereview.appspot.com/10883052/diff/1002/corelib/src/string....
corelib/src/string.dart:11: interface String extends Comparable,
On 2012/08/27 12:17:07, Mads Ager wrote:
> How about:
> 
> interface String
>     extends Comparable, Hashable, Pattern default StringImplementation {
> 
> or
> 
> interface String
>     extends Comparable, Hashable, Pattern
>     default StringImplementation {
> 
> ?

Going with nr 2, ty.

[Mads Ager (google), 2012-08-27 12:24:30]

LGTM