Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: corelib/src/implementation/string.dart

Issue 10883052: Unify String. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Style and add missing file. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « corelib/src/implementation/corelib_impl_sources.gypi ('k') | corelib/src/string.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: corelib/src/implementation/string.dart
diff --git a/corelib/src/strings.dart b/corelib/src/implementation/string.dart
similarity index 66%
copy from corelib/src/strings.dart
copy to corelib/src/implementation/string.dart
index 9462ee10eb9fc7a76f7e98f8c04f0b095f4bab52..4e23e675596a98b2e097de645162a712ef6ce303 100644
--- a/corelib/src/strings.dart
+++ b/corelib/src/implementation/string.dart
@@ -2,27 +2,25 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-class Strings {
-
+class StringImplementation {
/**
* Factory implementation of String.fromCharCodes:
* Allocates a new String for the specified [charCodes].
*/
factory String.fromCharCodes(List<int> charCodes) {
- return StringBase.createFromCharCodes(charCodes);
+ return _fromCharCodes(charCodes);
}
+ external static String _fromCharCodes(List<int> charCodes);
+
/**
* Joins all the given strings to create a new string.
*/
- static String join(List<String> strings, String separator) {
- return StringBase.join(strings, separator);
- }
+ external static String join(List<String> strings, String separator);
/**
* Concatenates all the given strings to create a new string.
*/
- static String concatAll(List<String> strings) {
- return StringBase.concatAll(strings);
- }
+ external static String concatAll(List<String> strings);
+
}
« no previous file with comments | « corelib/src/implementation/corelib_impl_sources.gypi ('k') | corelib/src/string.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698