Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 10882007: Re-enable checking of native resolvers. (Closed)

Created:
8 years, 4 months ago by regis
Modified:
8 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Re-enable checking of native resolvers. Committed: https://code.google.com/p/dart/source/detail?r=11206

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -17 lines) Patch
M runtime/tests/vm/vm.status View 1 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/class_finalizer.cc View 1 1 chunk +0 lines, -15 lines 0 comments Download
M runtime/vm/parser.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
8 years, 4 months ago (2012-08-23 01:38:45 UTC) #1
siva
lgtm https://chromiumcodereview.appspot.com/10882007/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://chromiumcodereview.appspot.com/10882007/diff/1/runtime/vm/parser.cc#newcode2073 runtime/vm/parser.cc:2073: // which do not have a native resolver. ...
8 years, 4 months ago (2012-08-23 01:47:56 UTC) #2
regis
8 years, 4 months ago (2012-08-23 03:26:05 UTC) #3
Thanks!

https://chromiumcodereview.appspot.com/10882007/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://chromiumcodereview.appspot.com/10882007/diff/1/runtime/vm/parser.cc#n...
runtime/vm/parser.cc:2073: // which do not have a native resolver.
On 2012/08/23 01:47:56, asiva wrote:
> We should probably add a comment that we delay this check until the class is
> actually used and invocation of a function in the class would be the first
point
> of use.
> 
> Access of const static fields in the class would not trigger an error, that is
> ok I suppose.

Done.

Powered by Google App Engine
This is Rietveld 408576698