Re-enable checking of native resolvers.

runtime/vm/parser.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/parser.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/compiler_stats.h"
@@ skipping 2051 matching lines @@
 // Parser is at the opening parenthesis of the formal parameter
 // declaration of the function or constructor.
 // Parse the formal parameters and code.
 SequenceNode* Parser::ParseFunc(const Function& func,
                                 Array& default_parameter_values) {
   TRACE_PARSER("ParseFunc");
   Function& saved_innermost_function =
       Function::Handle(innermost_function().raw());
   innermost_function_ = func.raw();
 
+  // Check to ensure we don't have classes with native fields in libraries
+  // which do not have a native resolver.

[siva, 2012/08/23 01:47:56]

We should probably add a comment that we delay this check until the class is
actually used and invocation of a function in the class would be the first point
of use.

Access of const static fields in the class would not trigger an error, that is
ok I suppose.

[regis, 2012/08/23 03:26:05]

Done.

+  if (current_class().num_native_fields() != 0) {
+    const Library& lib = Library::Handle(current_class().library());
+    if (lib.native_entry_resolver() == NULL) {
+      const String& cls_name = String::Handle(current_class().Name());
+      const String& lib_name = String::Handle(lib.url());
+      ErrorMsg(current_class().token_pos(),
+               "class '%s' is trying to extend a native fields class, "
+               "but library '%s' has no native resolvers",
+               cls_name.ToCString(), lib_name.ToCString());
+    }
+  }
+
   if (func.IsConstructor()) {
     SequenceNode* statements = ParseConstructor(func, default_parameter_values);
     innermost_function_ = saved_innermost_function.raw();
     return statements;
   }
 
   ASSERT(!func.IsConstructor());
   OpenFunctionBlock(func);  // Build local scope for function.
 
   ParamList params;
@@ skipping 7128 matching lines @@
 void Parser::SkipQualIdent() {
   ASSERT(IsIdentifier());
   ConsumeToken();
   if (CurrentToken() == Token::kPERIOD) {
     ConsumeToken();  // Consume the kPERIOD token.
     ExpectIdentifier("identifier expected after '.'");
   }
 }
 
 }  // namespace dart