Issue 10882004: Further broaden NSME test for IE.

Issue 10882004: Further broaden NSME test for IE. (Closed)

Created:
8 years, 4 months ago by Emily Fortuna

Modified:
8 years, 4 months ago

Reviewers:
ahe, sra1

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Further broaden NSME test for IE. Committed: https://code.google.com/p/dart/source/detail?r=11243

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	lib/compiler/implementation/lib/js_helper.dart	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
	M	tools/testing/perf_testing/run_perf_tests.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

Based on testing what I could on Windows, this seems to pass existing tests... O.o

8 years, 4 months ago (2012-08-22 23:48:03 UTC) #1

sra1

lgtm https://chromiumcodereview.appspot.com/10882004/diff/2001/lib/compiler/implementation/lib/js_helper.dart File lib/compiler/implementation/lib/js_helper.dart (right): https://chromiumcodereview.appspot.com/10882004/diff/2001/lib/compiler/implementation/lib/js_helper.dart#newcode820 lib/compiler/implementation/lib/js_helper.dart:820: // x.foo is not a function Add a ...

8 years, 4 months ago (2012-08-23 00:45:46 UTC) #2

Emily Fortuna

https://chromiumcodereview.appspot.com/10882004/diff/2001/lib/compiler/implementation/lib/js_helper.dart File lib/compiler/implementation/lib/js_helper.dart (right): https://chromiumcodereview.appspot.com/10882004/diff/2001/lib/compiler/implementation/lib/js_helper.dart#newcode820 lib/compiler/implementation/lib/js_helper.dart:820: // x.foo is not a function On 2012/08/23 00:45:46, ...

8 years, 4 months ago (2012-08-23 17:32:55 UTC) #3

ahe

8 years, 4 months ago (2012-08-24 07:01:27 UTC) #4

What is the planned solution for dealing with localized versions of IE? For
example, how is this supposed to work on a German version of IE?

I think you forgot to cc compiler-dev on this change, please remember to CC
compiler-dev on dart2jd changes.

Expand Messages | Collapse Messages