Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: lib/compiler/implementation/lib/js_helper.dart

Issue 10882004: Further broaden NSME test for IE. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/testing/perf_testing/run_perf_tests.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/lib/js_helper.dart
===================================================================
--- lib/compiler/implementation/lib/js_helper.dart (revision 11193)
+++ lib/compiler/implementation/lib/js_helper.dart (working copy)
@@ -815,9 +815,12 @@
message.endsWith('is undefined') ||
message.endsWith('is null or undefined')) {
return new NullPointerException();
- } else if (message.contains(' is not a function')) {
+ } else if (message.contains(' is not a function') ||
+ message.contains("doesn't support property or method")) {
+ // Examples:
// x.foo is not a function
// 'undefined' is not a function (evaluating 'x.foo(1,2,3)')
+ // Object doesn't support property or method 'foo'
// TODO(kasperl): Compute the right name if possible.
return new NoSuchMethodException('', '<unknown>', []);
}
« no previous file with comments | « no previous file | tools/testing/perf_testing/run_perf_tests.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698