Issue 10880003: Stop test_runner_test from failing when process_test times out instead of crashing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10880003: Stop test_runner_test from failing when process_test times out instead of crashing. (Closed)

Created:
8 years, 4 months ago by Bill Hesse

Modified:
8 years, 4 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Stop test_runner_test from failing when process_test times out instead of crashing. BUG=dart:1947 TEST=standalone/io/test_runner_test Committed: https://code.google.com/p/dart/source/detail?r=11130

Patch Set 2 : Fix typo in nearby comment. #

Total comments: 1

Patch Set 3 : Mark as flaky in status file, not by changing test. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -8 lines)			Patch
	M	tests/standalone/io/test_runner_test.dart	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
	M	tests/standalone/standalone.status	View	1 2	3 chunks	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

https://chromiumcodereview.appspot.com/10880003/diff/3001/tests/standalone/io/test_runner_test.dart File tests/standalone/io/test_runner_test.dart (right): https://chromiumcodereview.appspot.com/10880003/diff/3001/tests/standalone/io/test_runner_test.dart#newcode60 tests/standalone/io/test_runner_test.dart:60: // TODO(1947): Remove the TIMEOUT from this case when ...

8 years, 4 months ago (2012-08-22 09:06:36 UTC) #2

lgtm