Issue 10879010: Add named constants for all type codes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10879010: Add named constants for all type codes (Closed)

Created:
8 years, 4 months ago by Søren Gjesse

Modified:
8 years, 4 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add named constants for all type codes R=ngeoffray@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=11211

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -37 lines)			Patch
	M	lib/compiler/implementation/ssa/codegen.dart	View		1 chunk	+2 lines, -2 lines	2 comments	Download
	M	lib/compiler/implementation/ssa/nodes.dart	View		34 chunks	+66 lines, -35 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM! https://chromiumcodereview.appspot.com/10879010/diff/1/lib/compiler/implementation/ssa/codegen.dart File lib/compiler/implementation/ssa/codegen.dart (right): https://chromiumcodereview.appspot.com/10879010/diff/1/lib/compiler/implementation/ssa/codegen.dart#newcode1495 lib/compiler/implementation/ssa/codegen.dart:1495: if (Elements.isStaticOrTopLevelFunction(node.element) && Why this check? Why aren't ...

8 years, 4 months ago (2012-08-22 14:21:07 UTC) #2

Søren Gjesse

8 years, 4 months ago (2012-08-23 07:02:04 UTC) #3

http://codereview.chromium.org/10879010/diff/1/lib/compiler/implementation/ss...
File lib/compiler/implementation/ssa/codegen.dart (right):

http://codereview.chromium.org/10879010/diff/1/lib/compiler/implementation/ss...
lib/compiler/implementation/ssa/codegen.dart:1495: if
(Elements.isStaticOrTopLevelFunction(node.element) &&
On 2012/08/22 14:21:07, ngeoffray wrote:
> Why this check? Why aren't we unconditionally registering?

Good question. Removed.

Expand Messages | Collapse Messages