Add named constants for all type codes

lib/compiler/implementation/ssa/codegen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class SsaCodeGeneratorTask extends CompilerTask {
   final JavaScriptBackend backend;
   SsaCodeGeneratorTask(JavaScriptBackend backend)
       : this.backend = backend,
         super(backend.compiler);
   String get name => 'SSA code generator';
@@ skipping 1474 matching lines @@
     use(node.receiver);
     push(jsPropertyCall(pop(),
                         compiler.namer.closureInvocationName(node.selector),
                         visitArguments(node.inputs)),
          node);
     Selector call = new Selector.callClosureFrom(node.selector);
     world.registerDynamicInvocation(call.name, call);
   }
 
   visitInvokeStatic(HInvokeStatic node) {
     if (Elements.isStaticOrTopLevelFunction(node.element) &&

[ngeoffray, 2012/08/22 14:21:07]

Why this check? Why aren't we unconditionally registering?

[Søren Gjesse, 2012/08/23 07:02:04]

Good question. Removed.

-        (node.typeCode() == HInvokeStatic.INVOKE_STATIC_TYPECODE ||
-         node.typeCode() == HInvokeStatic.INVOKE_INTERCEPTOR_TYPECODE)) {
+        (node.typeCode() == HInstruction.INVOKE_STATIC_TYPECODE ||
+         node.typeCode() == HInstruction.INVOKE_INTERCEPTOR_TYPECODE)) {
       // Register this invocation to collect the types used at all call sites.
       backend.registerStaticInvocation(node, types);
     }
     use(node.target);
     push(new js.Call(pop(), visitArguments(node.inputs)), node);
   }
 
   visitInvokeSuper(HInvokeSuper node) {
     Element superMethod = node.element;
     Element superClass = superMethod.getEnclosingClass();
@@ skipping 1400 matching lines @@
   if (leftType.canBeNull() && rightType.canBeNull()) {
     if (left.isConstantNull() || right.isConstantNull() ||
         (leftType.isPrimitive() && leftType == rightType)) {
       return '==';
     }
     return null;
   } else {
     return '===';
   }
 }