Issue 10876052: If a PolymorphicInstanceCall has a single target, ..

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10876052: If a PolymorphicInstanceCall has a single target, .. (Closed)

Created:
8 years, 4 months ago by srdjan

Modified:
8 years, 4 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, Florian Schneider

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

If a PolymorphicInstanceCall has a single target, move its check into a separate class check so that it can get eliminated. Committed: https://code.google.com/p/dart/source/detail?r=11259

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -3 lines)			Patch
M	runtime/vm/flow_graph_optimizer.cc	View	1	1 chunk	+16 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1	1 chunk	+11 lines, -0 lines	1 comment	Download
M	runtime/vm/intermediate_language_x64.cc	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

8 years, 4 months ago (2012-08-23 21:08:09 UTC) #3

LGTM

https://chromiumcodereview.appspot.com/10876052/diff/7001/runtime/vm/intermed...
File runtime/vm/intermediate_language_ia32.cc (right):

https://chromiumcodereview.appspot.com/10876052/diff/7001/runtime/vm/intermed...
runtime/vm/intermediate_language_ia32.cc:1967: }
You could factorize this code that is repeated below. I suppose it is easier to
read this way. Fine with me.

Expand Messages | Collapse Messages