Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 10876052: If a PolymorphicInstanceCall has a single target, .. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/intermediate_language.h » ('j') | runtime/vm/intermediate_language_ia32.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_optimizer.cc
===================================================================
--- runtime/vm/flow_graph_optimizer.cc (revision 11256)
+++ runtime/vm/flow_graph_optimizer.cc (working copy)
@@ -538,9 +538,24 @@
}
const intptr_t kMaxChecks = 4;
if (comp->ic_data()->NumberOfChecks() <= kMaxChecks) {
- PolymorphicInstanceCallComp* call = new PolymorphicInstanceCallComp(comp);
const ICData& unary_checks =
ICData::ZoneHandle(comp->ic_data()->AsUnaryClassChecks());
+ bool call_with_checks;
+ // TODO(srdjan): Add check class comp for mixed smi/non-smi.
+ if (HasOneTarget(unary_checks) &&
+ (unary_checks.GetReceiverClassIdAt(0) != kSmiCid)) {
+ Value* value = comp->ArgumentAt(0)->value()->CopyValue();
+ // Type propagation has not run yet, we cannot eliminate the check.
+ CheckClassComp* check = new CheckClassComp(value, comp);
+ check->set_ic_data(&unary_checks);
+ InsertCheckBefore(instr, check, instr->env()->Copy());
+ // Call can still deoptimize, do not detach environment from instr.
+ call_with_checks = false;
+ } else {
+ call_with_checks = true;
+ }
+ PolymorphicInstanceCallComp* call =
+ new PolymorphicInstanceCallComp(comp, call_with_checks);
call->set_ic_data(&unary_checks);
instr->set_computation(call);
}
« no previous file with comments | « no previous file | runtime/vm/intermediate_language.h » ('j') | runtime/vm/intermediate_language_ia32.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698