Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 10873004: Use kInstanceCid instead of object_store()->object_class() when checking to see if the class is obj… (Closed)

Created:
8 years, 4 months ago by siva
Modified:
8 years, 4 months ago
Reviewers:
regis, srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Use kInstanceCid instead of object_store()->object_class() when checking to see if the class is object class. Committed: https://code.google.com/p/dart/source/detail?r=11190

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -42 lines) Patch
M vm/cha.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M vm/cha.cc View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
M vm/cha_test.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M vm/intermediate_language.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M vm/intermediate_language_ia32.cc View 3 chunks +3 lines, -9 lines 0 comments Download
M vm/intermediate_language_x64.cc View 3 chunks +3 lines, -9 lines 0 comments Download
M vm/object.cc View 1 3 chunks +2 lines, -4 lines 0 comments Download
M vm/resolver.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
siva
Regis, I deferred moving all these interfaces also to a fixed id in the class ...
8 years, 4 months ago (2012-08-22 01:11:16 UTC) #1
regis
LGTM Waiting for Matthias to land his cl sounds good to me. There are a ...
8 years, 4 months ago (2012-08-22 01:39:26 UTC) #2
siva
Included all references to kDartObjectCid. We are not using kDartObjectCid, This morning Srdjan, Ivan and ...
8 years, 4 months ago (2012-08-22 04:41:20 UTC) #3
regis
On 2012/08/22 04:41:20, asiva wrote: > Included all references to kDartObjectCid. Awesome. Thanks! > > ...
8 years, 4 months ago (2012-08-22 15:56:18 UTC) #4
srdjan
8 years, 4 months ago (2012-08-22 20:13:37 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698