vm/cha_test.cc - Issue 10873004: Use kInstanceCid instead of object_store()->object_class() when checking to see if the class is obj…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: vm/cha_test.cc

Issue 10873004: Use kInstanceCid instead of object_store()->object_class() when checking to see if the class is obj… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: vm/cha_test.cc

===================================================================

--- vm/cha_test.cc (revision 11121)

+++ vm/cha_test.cc (working copy)

@@ -115,7 +115,7 @@

EXPECT_EQ(1, class_a_bar_overrides->length());

EXPECT_EQ(class_d_bar.raw(), (*class_a_bar_overrides)[0]->raw());

- // TODO(regis): Add this test EXPECT(CHA::HasSubclasses(kDartObjectCid)).

+ EXPECT(CHA::HasSubclasses(kInstanceCid));

EXPECT(!CHA::HasSubclasses(kSmiCid));

EXPECT(!CHA::HasSubclasses(kNullCid));

EXPECT(!CHA::HasSubclasses(kDynamicCid));

@@ -127,4 +127,3 @@

}

} // namespace dart

« no previous file with comments | « vm/cha.cc ('k') | vm/intermediate_language.cc » ('j') | no next file with comments »