Issue 10872106: Fixed dartc test/build setup, so test can run on Windows. Might be related to dart:2623

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10872106: Fixed dartc test/build setup, so test can run on Windows. Might be related to dart:2623 (Closed)

Created:
8 years, 3 months ago by aam-me

Modified:
8 years, 3 months ago

Reviewers:
devoncarew, ahe, scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixed dartc test/build setup, so test can run on Windows. Might be related to dart:2623 BUG=dart:2623 TEST=run "tools\test.py -mrelease -cdartc -rnone" on windows and observe all test pass. Committed: https://code.google.com/p/dart/source/detail?r=11674

Patch Set 1 #

Patch Set 2 : Removed debugging printouts #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+167 lines, -8 lines)			Patch
M	compiler/build.xml	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	compiler/dart-compiler.gyp	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	compiler/dart_analyzer.xml	View		3 chunks	+13 lines, -1 line	0 comments	Download
A	compiler/scripts/dart_analyzer.bat	View	1	1 chunk	+139 lines, -0 lines	0 comments	Download
M	tools/testing/dart/test_runner.dart	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

Are you ready to have this reviewed? If you sent out an e-mail about it ...

8 years, 3 months ago (2012-08-30 16:46:47 UTC) #1

aam-me

Yes, Brian. I think I am ready. With this CL folks who run on Windows ...

8 years, 3 months ago (2012-08-30 16:57:09 UTC) #2

devoncarew

lgtm Looks good to me, though please wait for ahe's review, especially wrt the gyp ...

8 years, 3 months ago (2012-08-30 17:53:56 UTC) #3

ahe

8 years, 3 months ago (2012-08-30 18:05:10 UTC) #4

LGTM to GYP changes and tools/... changes.

Alexander, you're go for commit!

Expand Messages | Collapse Messages