Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 10872106: Fixed dartc test/build setup, so test can run on Windows. Might be related to dart:2623 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Removed debugging printouts Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « compiler/scripts/dart_analyzer.bat ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index ae166ac62321ae91fb14fff4e8dbccaae6f74c78..6fe4e2d720754d2e1d44ad0a6b7476afd9cbfee9 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -32,6 +32,12 @@ class Command {
String commandLine;
Command(this.executable, this.arguments) {
+ if (Platform.operatingSystem == 'windows') {
+ // Windows can't handle the first command if it is a .bat file or the like
+ // with the slashes going the other direction.
+ // TODO(efortuna): Remove this when fixed (Issue 1306).
+ executable = executable.replaceAll('/', '\\');
+ }
commandLine = "$executable ${Strings.join(arguments, ' ')}";
}
@@ -614,12 +620,6 @@ class RunningProcess {
void runCommand(Command command,
void exitHandler(int exitCode)) {
- if (Platform.operatingSystem == 'windows') {
- // Windows can't handle the first command if it is a .bat file or the like
- // with the slashes going the other direction.
- // TODO(efortuna): Remove this when fixed (Issue 1306).
- command.executable = command.executable.replaceAll('/', '\\');
- }
process = Process.start(command.executable, command.arguments);
process.onExit = exitHandler;
process.onError = (e) {
« no previous file with comments | « compiler/scripts/dart_analyzer.bat ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698