Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 10872048: Convert getter and catch syntax in tests; fix resulting bugs (Closed)

Created:
8 years, 4 months ago by Brian Wilkerson
Modified:
8 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Convert getter and catch syntax in tests; fix resulting bugs Committed: https://code.google.com/p/dart/source/detail?r=11316

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -79 lines) Patch
M compiler/java/com/google/dart/compiler/parser/DartParser.java View 3 chunks +7 lines, -3 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/NonStrictResolutionTest.dart View 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother0.dart View 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother0.fillthehole.dart View 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother0.fillthemethodhole.dart View 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother0.fillthenothole.dart View 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother0.globalfunctionchange.dart View 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother0.globalvarchange.dart View 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother0.newstaticmethod.dart View 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother0.returntypechange.dart View 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/some.dart View 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/some.intfchange.dart View 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/some.newmethod.dart View 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/someimpl.dart View 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/someimpl.bodychange.dart View 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/someimpl.change.dart View 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/CatchFinally.dart View 5 chunks +11 lines, -45 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/ClassesInterfaces.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/DartASTValidator.java View 2 chunks +17 lines, -2 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/StringBuffer.dart View 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/TryCatch.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/resolver/StaticSuperGetterNegativeTest.dart View 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/covariant_class.dart View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Brian Wilkerson
8 years, 4 months ago (2012-08-23 21:20:29 UTC) #1
scheglov
8 years, 4 months ago (2012-08-24 00:39:05 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698