Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: compiler/java/com/google/dart/compiler/parser/DartParser.java

Issue 10872048: Convert getter and catch syntax in tests; fix resulting bugs (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | compiler/javatests/com/google/dart/compiler/end2end/NonStrictResolutionTest.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiler/java/com/google/dart/compiler/parser/DartParser.java
===================================================================
--- compiler/java/com/google/dart/compiler/parser/DartParser.java (revision 11234)
+++ compiler/java/com/google/dart/compiler/parser/DartParser.java (working copy)
@@ -4701,7 +4701,8 @@
if (peekPseudoKeyword(0, ON_KEYWORD)) {
beginCatchClause();
next();
- DartTypeNode exceptionType = new DartTypeNode(parseQualified());
+ beginTypeAnnotation();
+ DartTypeNode exceptionType = done(new DartTypeNode(parseQualified()));
DartParameter exception = null;
DartParameter stackTrace = null;
if (optional(Token.CATCH)) {
@@ -4717,8 +4718,10 @@
expectCloseParen();
} else {
// Create a dummy identifier that the user cannot reliably reference.
- DartIdentifier exceptionName = new DartIdentifier("e" + Long.toHexString(System.currentTimeMillis()));
- exception = new DartParameter(exceptionName, exceptionType, null, null, Modifiers.NONE);
+ beginCatchParameter();
+ beginIdentifier();
+ DartIdentifier exceptionName = done(new DartIdentifier("e" + Long.toHexString(System.currentTimeMillis())));
+ exception = done(new DartParameter(exceptionName, exceptionType, null, null, Modifiers.NONE));
}
DartBlock block = parseBlock();
catches.add(done(new DartCatchBlock(block, exception, stackTrace)));
@@ -4744,6 +4747,7 @@
stackTrace = done(new DartParameter(stackName, null, null, null, Modifiers.NONE));
} else {
// Old-style parameter
+ //reportError(position(), ParserErrorCode.DEPRECATED_CATCH);
stackTrace = parseCatchParameter();
}
}
« no previous file with comments | « no previous file | compiler/javatests/com/google/dart/compiler/end2end/NonStrictResolutionTest.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698