Issue 10871060: Reland "Add a simple dominator based redundancy elimination" and fix a register allocation bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10871060: Reland "Add a simple dominator based redundancy elimination" and fix a register allocation bug. (Closed)

Created:
8 years, 4 months ago by Florian Schneider

Modified:
8 years, 4 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Reland "Add a simple dominator based redundancy elimination" and fix a register allocation bug. Original CL: http://codereview.chromium.org/10872035/ It enables elimination of redundant expressions across basic blocks. Currently used for smi checks and class checks, but will be extended to other expressions in a separate CL. Additionally, this fixes a bug in the register allocator where a blocked register was illegally assigned to an unallocated live range. It also fixes a Mac compiler issue with the constructor of DirectChainedHashMap. Committed: https://code.google.com/p/dart/source/detail?r=11302

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -36 lines)			Patch
M	runtime/vm/compiler.cc	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	runtime/vm/flow_graph.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_allocator.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_optimizer.h	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 chunk	+37 lines, -21 lines	0 comments	Download
M	runtime/vm/hash_map.h	View	3 chunks	+18 lines, -2 lines	0 comments	Download
M	runtime/vm/hash_map_test.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages