runtime/vm/flow_graph_allocator.cc - Issue 10871060: Reland "Add a simple dominator based redundancy elimination" and fix a register allocation bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_allocator.cc

Issue 10871060: Reland "Add a simple dominator based redundancy elimination" and fix a register allocation bug. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_allocator.cc

===================================================================

--- runtime/vm/flow_graph_allocator.cc (revision 11228)

+++ runtime/vm/flow_graph_allocator.cc (working copy)

@@ -1586,7 +1586,7 @@

const UsePosition* use =

allocated->finger()->FirstRegisterBeneficialUse(unallocated->Start());

- if ((use != NULL) && ((use->pos() - start) <= 1)) {

+ if ((use != NULL) && ((ToInstructionStart(use->pos()) - start) <= 1)) {

// This register is blocked by interval that is used

// as register in the current instruction and can't

// be spilled.

« no previous file with comments | « runtime/vm/flow_graph.h ('k') | runtime/vm/flow_graph_optimizer.h » ('j') | no next file with comments »