Throw a NoSuchMethodException when attempting to call an undefined constructor.

Throw a NoSuchMethodException when attempting to call an undefined constructor.

R=ngeoffray@google.com
BUG=3802
Committed: https://code.google.com/p/dart/source/detail?r=11220

[ngeoffray, 2012-08-23 10:25:05]

LGTM, with test changes.

https://chromiumcodereview.appspot.com/10870037/diff/3001/lib/compiler/implem...
File lib/compiler/implementation/resolver.dart (right):

https://chromiumcodereview.appspot.com/10870037/diff/3001/lib/compiler/implem...
lib/compiler/implementation/resolver.dart:1537: var visitor = new
ConstructorResolver(compiler, this, node.isConst());
var -> ConstructorResolver

https://chromiumcodereview.appspot.com/10870037/diff/3001/lib/compiler/implem...
File lib/compiler/implementation/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/10870037/diff/3001/lib/compiler/implem...
lib/compiler/implementation/ssa/builder.dart:2430: // TODO(karlklose): generate
runtime error or noSuchMethodCall, depending
Remove TODO.

https://chromiumcodereview.appspot.com/10870037/diff/3001/lib/compiler/implem...
lib/compiler/implementation/ssa/builder.dart:2453:
compiler.cancel('Unimplemented unresolved constructor call',
Maybe use the message local variable instead to give a better internal error.

https://chromiumcodereview.appspot.com/10870037/diff/3001/tests/language/call...
File tests/language/call_nonexistent_constructor_test.dart (right):

https://chromiumcodereview.appspot.com/10870037/diff/3001/tests/language/call...
tests/language/call_nonexistent_constructor_test.dart:1: // Copyright (c) 2011,
the Dart project authors.  Please see the AUTHORS file
2011 -> 2012

https://chromiumcodereview.appspot.com/10870037/diff/3001/tests/language/call...
tests/language/call_nonexistent_constructor_test.dart:21: } catch (e) {
This is actually not checking :) You need to make sure e was thrown. Also I
think you should the exception is of type String.

https://chromiumcodereview.appspot.com/10870037/diff/3001/tests/language/call...
tests/language/call_nonexistent_constructor_test.dart:25: } catch
(NoSuchMethodException e) {
ditto

[karlklose, 2012-08-23 11:05:56]

Thanks, Nicolas. PTAL.

https://chromiumcodereview.appspot.com/10870037/diff/3001/lib/compiler/implem...
File lib/compiler/implementation/resolver.dart (right):

https://chromiumcodereview.appspot.com/10870037/diff/3001/lib/compiler/implem...
lib/compiler/implementation/resolver.dart:1537: var visitor = new
ConstructorResolver(compiler, this, node.isConst());
On 2012/08/23 10:25:05, ngeoffray wrote:
> var -> ConstructorResolver

Done.

https://chromiumcodereview.appspot.com/10870037/diff/3001/lib/compiler/implem...
File lib/compiler/implementation/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/10870037/diff/3001/lib/compiler/implem...
lib/compiler/implementation/ssa/builder.dart:2430: // TODO(karlklose): generate
runtime error or noSuchMethodCall, depending
On 2012/08/23 10:25:05, ngeoffray wrote:
> Remove TODO.

Done.

https://chromiumcodereview.appspot.com/10870037/diff/3001/lib/compiler/implem...
lib/compiler/implementation/ssa/builder.dart:2453:
compiler.cancel('Unimplemented unresolved constructor call',
This branch is currently unreachable. I will implement it in my next CL, so this
will go away.

https://chromiumcodereview.appspot.com/10870037/diff/3001/tests/language/call...
File tests/language/call_nonexistent_constructor_test.dart (right):

https://chromiumcodereview.appspot.com/10870037/diff/3001/tests/language/call...
tests/language/call_nonexistent_constructor_test.dart:1: // Copyright (c) 2011,
the Dart project authors.  Please see the AUTHORS file
On 2012/08/23 10:25:05, ngeoffray wrote:
> 2011 -> 2012

Done.

https://chromiumcodereview.appspot.com/10870037/diff/3001/tests/language/call...
tests/language/call_nonexistent_constructor_test.dart:21: } catch (e) {
On 2012/08/23 10:25:05, ngeoffray wrote:
> This is actually not checking :) You need to make sure e was thrown. Also I
> think you should the exception is of type String.

Done.

https://chromiumcodereview.appspot.com/10870037/diff/3001/tests/language/call...
tests/language/call_nonexistent_constructor_test.dart:25: } catch
(NoSuchMethodException e) {
On 2012/08/23 10:25:05, ngeoffray wrote:
> ditto

Done.

[ngeoffray, 2012-08-23 11:09:02]

LGTM!

https://chromiumcodereview.appspot.com/10870037/diff/7002/tests/language/call...
File tests/language/call_nonexistent_constructor_test.dart (right):

https://chromiumcodereview.appspot.com/10870037/diff/7002/tests/language/call...
tests/language/call_nonexistent_constructor_test.dart:22: } catch (String e) {
Personal preference and you don't have to do it, but catching all and then
checking the type reads nicer to me, compared to checking an integer.

https://chromiumcodereview.appspot.com/10870037/diff/7002/tests/language/call...
tests/language/call_nonexistent_constructor_test.dart:29: i = 2;
ditto

[ahe, 2012-09-21 09:35:45]

https://chromiumcodereview.appspot.com/10870037/diff/7002/lib/compiler/implem...
File lib/compiler/implementation/resolver.dart (right):

https://chromiumcodereview.appspot.com/10870037/diff/7002/lib/compiler/implem...
lib/compiler/implementation/resolver.dart:2355: final bool inConstContext;
What is this for?

https://chromiumcodereview.appspot.com/10870037/diff/7002/lib/compiler/implem...
lib/compiler/implementation/resolver.dart:2358: [bool this.inConstContext =
false])
Why is this argument optional?

https://chromiumcodereview.appspot.com/10870037/diff/7002/lib/compiler/implem...
lib/compiler/implementation/resolver.dart:2377: error(diagnosticNode,
MessageKind.CANNOT_FIND_CONSTRUCTOR,
Why is this not returning an erroneous element?