Throw a NoSuchMethodException when attempting to call an undefined constructor.

lib/compiler/implementation/ssa/builder.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class Interceptors {
   Compiler compiler;
   Interceptors(Compiler this.compiler);
 
   SourceString mapOperatorToMethodName(Operator op) {
     String name = op.source.stringValue;
@@ skipping 1853 matching lines @@
   }
 
   void pushInvokeHelper2(Element helper, HInstruction a0, HInstruction a1) {
     HInstruction reference = new HStatic(helper);
     add(reference);
     List<HInstruction> inputs = <HInstruction>[reference, a0, a1];
     HInstruction result = new HInvokeStatic(inputs);
     push(result);
   }
 
+  void pushInvokeHelper3(Element helper, HInstruction a0, HInstruction a1,
+                         HInstruction a2) {
+    HInstruction reference = new HStatic(helper);
+    add(reference);
+    List<HInstruction> inputs = <HInstruction>[reference, a0, a1, a2];
+    HInstruction result = new HInvokeStatic(inputs);
+    push(result);
+  }
+
   visitOperatorSend(node) {
     assert(node.selector is Operator);
     if (!methodInterceptionEnabled) {
       visitDynamicSend(node);
       return;
     }
 
     Operator op = node.selector;
     if (const SourceString("[]") == op.source) {
       HStatic target = new HStatic(interceptors.getIndexInterceptor());
@@ skipping 527 matching lines @@
         return selector.receiver;
       }
     } else {
       compiler.internalError("malformed send in new expression");
     }
   }
 
   visitNewExpression(NewExpression node) {
     Element element = elements[node.send];
     if (Element.isInvalid(element)) {
       // TODO(karlklose): generate runtime error or noSuchMethodCall, depending

[ngeoffray, 2012/08/23 10:25:05]

Remove TODO.

[karlklose, 2012/08/23 11:05:56]

Done.

       // on whether element is null or it is an erroneous element with a
       // particular error message.
-      compiler.cancel('Unimplemented unresolved constructor call', node: node);
+      ErroneousElement error = element;
+      Message message = error.errorMessage;
+      if (message.kind === MessageKind.CANNOT_FIND_CONSTRUCTOR) {
+        Element helper =
+            compiler.findHelper(const SourceString('throwNoSuchMethod'));
+        DartString receiverLiteral = new DartString.literal('');
+        HInstruction receiver = graph.addConstantString(receiverLiteral, node);
+        String constructorName = 'constructor ${message.arguments[0]}';
+        DartString nameLiteral = new DartString.literal(constructorName);
+        HInstruction name = graph.addConstantString(nameLiteral, node.send);
+        List<HInstruction> inputs = <HInstruction>[];
+        node.send.arguments.forEach((argumentNode) {
+          visit(argumentNode);
+          HInstruction value = pop();
+          inputs.add(value);
+        });
+        HInstruction arguments = new HLiteralList(inputs);
+        add(arguments);
+        pushInvokeHelper3(helper, receiver, name, arguments);
+      } else {
+        compiler.cancel('Unimplemented unresolved constructor call',

[ngeoffray, 2012/08/23 10:25:05]

Maybe use the message local variable instead to give a better internal error.

[karlklose, 2012/08/23 11:05:56]

This branch is currently unreachable. I will implement it in my next CL, so this
will go away.

+                        node: node);
+      }
     } else if (node.isConst()) {
       // TODO(karlklose): add type representation
       ConstantHandler handler = compiler.constantHandler;
       Constant constant = handler.compileNodeWithDefinitions(node, elements);
       stack.add(graph.addConstant(constant));
     } else {
       visitNewSend(node.send);
     }
   }
 
@@ skipping 1211 matching lines @@
           new HSubGraphBlockInformation(elseBranch.graph));
 
     HBasicBlock conditionStartBlock = conditionBranch.block;
     conditionStartBlock.setBlockFlow(info, joinBlock);
     SubGraph conditionGraph = conditionBranch.graph;
     HIf branch = conditionGraph.end.last;
     assert(branch is HIf);
     branch.blockInformation = conditionStartBlock.blockFlow;
   }
 }