Reify partial metadata.

Reify partial metadata.

Committed: https://code.google.com/p/dart/source/detail?r=11152

[Johnni Winther, 2012-08-22 13:25:20]

https://chromiumcodereview.appspot.com/10869013/diff/1/dart/lib/compiler/impl...
File dart/lib/compiler/implementation/scanner/parser.dart (right):

https://chromiumcodereview.appspot.com/10869013/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/scanner/parser.dart:66: */
The stated grammar describes a sequence of metadata whereas the method only
parses one occurrence.

https://chromiumcodereview.appspot.com/10869013/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/scanner/parser.dart:73: token =
parseQualifiedRestOpt(token);
Why call this twice? It doesn't the stated grammar.

[ahe, 2012-08-22 13:36:47]

Hi Johnni,

Thank you for taking a look.

Cheers,
Peter

https://chromiumcodereview.appspot.com/10869013/diff/1/dart/lib/compiler/impl...
File dart/lib/compiler/implementation/scanner/parser.dart (right):

https://chromiumcodereview.appspot.com/10869013/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/scanner/parser.dart:66: */
On 2012/08/22 13:25:20, Johnni Winther wrote:
> The stated grammar describes a sequence of metadata whereas the method only
> parses one occurrence.

See below.

https://chromiumcodereview.appspot.com/10869013/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/scanner/parser.dart:73: token =
parseQualifiedRestOpt(token);
On 2012/08/22 13:25:20, Johnni Winther wrote:
> Why call this twice? It doesn't the stated grammar. 

qualified is:

identifier ('.' identifier)?

So what the above grammar snippet says is:

identifier ('.' identifier)? ('.' identifier)?

parseQualifiedRestOpt is exactly parsing this:

('.' identifier)?

[Johnni Winther, 2012-08-22 13:48:56]

LGTM with comments.

https://chromiumcodereview.appspot.com/10869013/diff/1/dart/lib/compiler/impl...
File dart/lib/compiler/implementation/scanner/parser.dart (right):

https://chromiumcodereview.appspot.com/10869013/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/scanner/parser.dart:66: */
On 2012/08/22 13:36:47, ahe wrote:
> On 2012/08/22 13:25:20, Johnni Winther wrote:
> > The stated grammar describes a sequence of metadata whereas the method only
> > parses one occurrence.
> 
> See below.

I think the comment describes parseMetadataStar whereas parseMetaData should
have the grammar [: '@' qualified (‘.’ identifier)? (arguments)? :], i.e.
without the star.

https://chromiumcodereview.appspot.com/10869013/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/scanner/parser.dart:73: token =
parseQualifiedRestOpt(token);
On 2012/08/22 13:36:47, ahe wrote:
> On 2012/08/22 13:25:20, Johnni Winther wrote:
> > Why call this twice? It doesn't the stated grammar. 
> 
> qualified is:
> 
> identifier ('.' identifier)?
> 
> So what the above grammar snippet says is:
> 
> identifier ('.' identifier)? ('.' identifier)?
> 
> parseQualifiedRestOpt is exactly parsing this:
> 
> ('.' identifier)?

Ahhh!

[ahe, 2012-08-22 13:53:10]

https://chromiumcodereview.appspot.com/10869013/diff/1/dart/lib/compiler/impl...
File dart/lib/compiler/implementation/scanner/parser.dart (right):

https://chromiumcodereview.appspot.com/10869013/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/scanner/parser.dart:66: */
On 2012/08/22 13:48:56, Johnni Winther wrote:
> On 2012/08/22 13:36:47, ahe wrote:
> > On 2012/08/22 13:25:20, Johnni Winther wrote:
> > > The stated grammar describes a sequence of metadata whereas the method
only
> > > parses one occurrence.
> > 
> > See below.
> 
> I think the comment describes parseMetadataStar whereas parseMetaData should
> have the grammar [: '@' qualified (‘.’ identifier)? (arguments)? :], i.e.
> without the star.

Correct. Thank you, I couldn't see it.

[ahe, 2012-08-22 14:15:55]

https://chromiumcodereview.appspot.com/10869013/diff/1/dart/lib/compiler/impl...
File dart/lib/compiler/implementation/scanner/parser.dart (right):

https://chromiumcodereview.appspot.com/10869013/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/scanner/parser.dart:66: */
On 2012/08/22 13:53:10, ahe wrote:
> On 2012/08/22 13:48:56, Johnni Winther wrote:
> > On 2012/08/22 13:36:47, ahe wrote:
> > > On 2012/08/22 13:25:20, Johnni Winther wrote:
> > > > The stated grammar describes a sequence of metadata whereas the method
> only
> > > > parses one occurrence.
> > > 
> > > See below.
> > 
> > I think the comment describes parseMetadataStar whereas parseMetaData should
> > have the grammar [: '@' qualified (‘.’ identifier)? (arguments)? :], i.e.
> > without the star.
> 
> Correct. Thank you, I couldn't see it.

Done.

[ngeoffray, 2012-08-22 14:32:02]

LGTM