Issue 10866021: Simplify HInvokeInterceptor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10866021: Simplify HInvokeInterceptor. (Closed)

Created:
8 years, 4 months ago by kasperl

Modified:
8 years, 4 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Simplify HInvokeInterceptor. R=ngeoffray@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=11153

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -33 lines)			Patch
M	lib/compiler/implementation/ssa/builder.dart	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	lib/compiler/implementation/ssa/codegen.dart	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	lib/compiler/implementation/ssa/nodes.dart	View	4 chunks	+8 lines, -14 lines	1 comment	Download
M	lib/compiler/implementation/ssa/optimize.dart	View	2 chunks	+6 lines, -10 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

8 years, 4 months ago (2012-08-22 13:58:54 UTC) #2

LGTM!

https://chromiumcodereview.appspot.com/10866021/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/nodes.dart (right):

https://chromiumcodereview.appspot.com/10866021/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/nodes.dart:1333: // TODO(kasperl): Should we
check that the selector is a call selector?
I think not checking is ok. If it's a getter, you still want the input to be a
mutable array, because the getter turns the add method into a closure that may
be called later on.

https://chromiumcodereview.appspot.com/10866021/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/optimize.dart (right):

https://chromiumcodereview.appspot.com/10866021/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/optimize.dart:669:
lengthInterceptor.getLibrary());  // TODO(kasperl): Wrong.
Actually, I think the instruction to create should probably be a HFieldGet. It
just happens that in the codegen this will be emitted as foo.length, and not a
call to the interceptor. So I think using the interceptor here was wrong from
the beginning.

Expand Messages | Collapse Messages