Simplify HInvokeInterceptor.

lib/compiler/implementation/ssa/optimize.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 interface OptimizationPhase {
   String get name();
   void visitGraph(HGraph graph);
 }
 
 class SsaOptimizerTask extends CompilerTask {
@@ skipping 188 matching lines @@
         ListConstant constant = constantInput.constant;
         return graph.addConstantInt(constant.length);
       } else if (input.isConstantMap()) {
         HConstant constantInput = input;
         MapConstant constant = constantInput.constant;
         return graph.addConstantInt(constant.length);
       }
     }
 
     if (input.isString(types)
-        && node.name == const SourceString('toString')) {
+        && node.selector.name == const SourceString('toString')) {
       return node.inputs[1];
     }
 
-    if (!input.canBePrimitive(types) && !node.getter && !node.setter) {
+    if (!input.canBePrimitive(types) && node.selector.isCall()) {
       bool transformToDynamicInvocation = true;
       if (input.canBeNull(types)) {
         // Check if the method exists on Null. If yes we must not transform
         // the static interceptor call to a dynamic invocation.
         // TODO(floitsch): get a list of methods that exist on 'null' and only
         // bail out on them.
         transformToDynamicInvocation = false;
       }
       if (transformToDynamicInvocation) {
         return fromInterceptorToDynamicInvocation(node, node.selector);
@@ skipping 433 matching lines @@
       instruction = instruction.accept(this);
       instruction = next;
     }
   }
 
   HBoundsCheck insertBoundsCheck(HInstruction node,
                                  HInstruction receiver,
                                  HInstruction index) {
     HStatic interceptor = new HStatic(lengthInterceptor);
     node.block.addBefore(node, interceptor);
-    Selector selector = new Selector.call(
-        lengthInterceptor.name,
-        lengthInterceptor.getLibrary(),  // TODO(kasperl): Wrong.
-        0);
+    Selector selector = new Selector.getter(
+        const SourceString('length'),
+        lengthInterceptor.getLibrary());  // TODO(kasperl): Wrong.

[ngeoffray, 2012/08/22 13:58:54]

Actually, I think the instruction to create should probably be a HFieldGet. It
just happens that in the codegen this will be emitted as foo.length, and not a
call to the interceptor. So I think using the interceptor here was wrong from
the beginning.

     HInvokeInterceptor length = new HInvokeInterceptor(
-        selector,
-        const SourceString("length"),
-        <HInstruction>[interceptor, receiver],
-        getter: true);
+        selector, <HInstruction>[interceptor, receiver]);
     types[length] = HType.INTEGER;
     node.block.addBefore(node, length);
 
     HBoundsCheck check = new HBoundsCheck(index, length);
     node.block.addBefore(node, check);
     return check;
   }
 
   HIntegerCheck insertIntegerCheck(HInstruction node, HInstruction value) {
     HIntegerCheck check = new HIntegerCheck(value);
@@ skipping 645 matching lines @@
       // this type for the field is still a strong signal
       // indicating the expected type of the field.
       types[field] = type;
     } else {
       // If there are no invoked setters we know the type of
       // this field for sure.
       field.guaranteedType = type;
     }
   }
 }