Issue 10866017: dart2dart Fix type variables rename

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10866017: dart2dart Fix type variables rename (Closed)

Created:
8 years, 4 months ago by Roman

Modified:
8 years, 4 months ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

dart2dart Fix type variables rename Committed: https://code.google.com/p/dart/source/detail?r=11140

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -13 lines)			Patch
	M	lib/compiler/implementation/dart_backend/placeholder_collector.dart	View		2 chunks	+13 lines, -10 lines	2 comments	Download
	M	tests/compiler/dart2js/unparser_test.dart	View		2 chunks	+14 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

LGTM if answer to the question is yes. Overall, please, try to be more specific ...

8 years, 4 months ago (2012-08-22 12:34:53 UTC) #2

Roman

I'll try to be more specific and provide examples :) https://chromiumcodereview.appspot.com/10866017/diff/1/lib/compiler/implementation/dart_backend/placeholder_collector.dart File lib/compiler/implementation/dart_backend/placeholder_collector.dart (right): https://chromiumcodereview.appspot.com/10866017/diff/1/lib/compiler/implementation/dart_backend/placeholder_collector.dart#newcode455 ...

8 years, 4 months ago (2012-08-22 12:38:22 UTC) #3

Thanks a lot for explanations, Roma, still LGTM

Expand Messages | Collapse Messages