dart2dart Fix type variables rename

lib/compiler/implementation/dart_backend/placeholder_collector.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class LocalPlaceholder implements Hashable {
   final String identifier;
   final Set<Node> nodes;
   LocalPlaceholder(this.identifier) : nodes = new Set<Node>();
   int hashCode() => identifier.hashCode();
   String toString() =>
@@ skipping 424 matching lines @@
         }
       }
     }
     node.visitChildren(this);
   }
 
   visitClassNode(ClassNode node) {
     assert(currentElement is ClassElement);
     makeElementPlaceholder(node.name, currentElement);
     node.visitChildren(this);
-    if (node.typeParameters !== null) {
-      // Another poor man resolution.
-      final typeVariableTypes =
-          new List<Type>.from(currentElement.typeVariables);
-      int i = 0;
-      for (TypeVariable typeVariable in node.typeParameters) {
-        makeTypePlaceholder(typeVariable.name, typeVariableTypes[i]);
-        i++;
-      }
-    }
     if (node.defaultClause !== null) {
       // Can't just visit class node's default clause because of the bug in the
       // resolver, it just crashes when it meets type variable.
       Type defaultType = (currentElement as ClassElement).defaultClass;
       assert(defaultType !== null);
       makeTypePlaceholder(node.defaultClause.typeName, defaultType);
       visit(node.defaultClause.typeArguments);
     }
   }
 
+  visitTypeVariable(TypeVariable node) {

[Anton Muhin, 2012/08/22 12:34:53]

it fixes a case with typedefs too?

[Roman, 2012/08/22 12:38:22]

Yes, there's a test for it in unparser_test. At first I wanted to create
visitTypedef, but realized this is a common case.

+    assert(currentElement is TypedefElement || currentElement is ClassElement);
+    // Another poor man type resolution.
+    // Find this variable in current element type parameters.
+    for (Type type in currentElement.typeVariables) {
+      if (type.name.slowToString() == node.name.source.slowToString()) {
+        makeTypePlaceholder(node.name, type);
+        break;
+      }
+    }
+    node.visitChildren(this);
+  }
+
   visitTypedef(Typedef node) {
     assert(currentElement is TypedefElement);
     makeElementPlaceholder(node.name, currentElement);
     node.visitChildren(this);
   }
 }