Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 10854066: Start moving the JavaScript backend related code into a separate library (Closed)

Created:
8 years, 4 months ago by Søren Gjesse
Modified:
8 years, 4 months ago
Reviewers:
ahe, floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Start moving the JavaScript backend related code into a separate library R=ahe@google.com, floitsch@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10479 Committed: https://code.google.com/p/dart/source/detail?r=10482

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Add missing import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -1894 lines) Patch
M lib/compiler/implementation/compiler.dart View 2 chunks +1 line, -271 lines 0 comments Download
D lib/compiler/implementation/emitter.dart View 1 chunk +0 lines, -1182 lines 0 comments Download
A lib/compiler/implementation/js_backend/backend.dart View 1 chunk +273 lines, -0 lines 0 comments Download
A + lib/compiler/implementation/js_backend/emitter.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/compiler/implementation/js_backend/js_backend.dart View 1 chunk +8 lines, -4 lines 0 comments Download
A + lib/compiler/implementation/js_backend/native_emitter.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M lib/compiler/implementation/leg.dart View 2 chunks +1 line, -3 lines 0 comments Download
D lib/compiler/implementation/native_emitter.dart View 1 chunk +0 lines, -435 lines 0 comments Download
M lib/compiler/implementation/native_handler.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M lib/compiler/implementation/ssa/ssa.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Søren Gjesse
8 years, 4 months ago (2012-08-09 15:43:44 UTC) #1
floitsch
LGTM.
8 years, 4 months ago (2012-08-09 15:52:53 UTC) #2
ahe
LGTM!
8 years, 4 months ago (2012-08-09 16:56:01 UTC) #3
Søren Gjesse
Reapplying with the fix in patch set #3. Tests now run in checked mode as ...
8 years, 4 months ago (2012-08-10 08:49:06 UTC) #4
floitsch
Still LGTM.
8 years, 4 months ago (2012-08-10 09:05:09 UTC) #5
ahe
8 years, 4 months ago (2012-08-10 10:19:00 UTC) #6
Still LGTM!

Powered by Google App Engine
This is Rietveld 408576698